From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee.jones@linaro.org, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
phh@phh.me, b.galvani@gmail.com, stefan@agner.ch,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 5/5] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver
Date: Fri, 29 Nov 2019 09:55:00 +0100 [thread overview]
Message-ID: <20191129085500.GV299836@piout.net> (raw)
In-Reply-To: <20191129075940.3b1c2631@kemnade.info>
On 29/11/2019 07:59:40+0100, Andreas Kemnade wrote:
> > > + /* disable interrupt */
> > > + err = rc5t619_rtc_alarm_enable(&pdev->dev, 0);
> > > + if (err)
> > > + return err;
> >
> > Is it really useful to disable the alarm to reenable them later?
> >
> Well, yes, seems to be nonsense.
> Am I right that I do not need to prevent alarm irqs between
> alloc() and register()?
>
That's fine, the core will be ready to handle alarms after alloc()
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-29 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:38 [PATCH v2 0/5] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-10-31 21:38 ` [PATCH v2 1/5] mfd: rn5t618: prepare for irq handling Andreas Kemnade
2019-11-16 0:41 ` kbuild test robot
2019-10-31 21:38 ` [PATCH v2 2/5] mfd: rn5t618: add irq support Andreas Kemnade
2019-11-06 21:48 ` Andreas Kemnade
2019-11-16 6:52 ` kbuild test robot
2019-11-20 7:54 ` Pierre-Hugues Husson
2019-11-20 8:13 ` Andreas Kemnade
2019-10-31 21:38 ` [PATCH v2 3/5] mfd: rn5t618: add rtc related registers Andreas Kemnade
2019-10-31 21:38 ` [PATCH v2 4/5] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-10-31 21:38 ` [PATCH v2 5/5] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver Andreas Kemnade
2019-11-28 10:57 ` Alexandre Belloni
2019-11-29 6:59 ` Andreas Kemnade
2019-11-29 8:55 ` Alexandre Belloni [this message]
2019-11-29 11:25 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129085500.GV299836@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andreas@kemnade.info \
--cc=b.galvani@gmail.com \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=phh@phh.me \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).