From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3021DC432C0 for ; Fri, 29 Nov 2019 23:33:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAD8C2464C for ; Fri, 29 Nov 2019 23:32:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dUF1VweB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387397AbfK2Xcz (ORCPT ); Fri, 29 Nov 2019 18:32:55 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23576 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727097AbfK2Xcy (ORCPT ); Fri, 29 Nov 2019 18:32:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575070373; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WhdAPdS+FPZ3dgyUmfDfDLG8hWWC09Bk50fcphiVxF8=; b=dUF1VweBz2EXerQg7lX51q5zZVNpnUogKnywx4zZQj3fcVr632b1KZwLp0AqM5QH5Rpmig IpHZMbu3ot0ZV54keuY7PTFnOzEMb/RmEhclORsK6WH+O3RT3Sj74CpfTRR+rUDxHMP9WJ As1fUx8zXxjJPZZOi8kHidmdner6S6Q= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-q2QRIjVLOrmGeWpQ35DlJQ-1; Fri, 29 Nov 2019 18:32:50 -0500 Received: by mail-pg1-f199.google.com with SMTP id v10so17402454pgg.3 for ; Fri, 29 Nov 2019 15:32:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=HMDoKlR2zf3F9JvmSD977gMi1kegZrPiHW0J/3/orrg=; b=tBvMQ6sGaNoUf40uwro65DDkGbA9TQ0h+NOczuMwmM89D3xiDOOkEwVvoQrJ6Pbm9u UjecR/eoYVHFkyVb8Q/eZxtsft60eh/gxjVdvpA9iVwqcrX6xfbqZ+Srnm+8d1ptzM+R sPTzTHViff7hK+MndR+MkNqWlrhTu7L+Va7ZBGJhd4+7MtwBL5WrhC7KDwjauXWKaHKe tDd/AXvFrHqJ9aYlCac19dd3nkiD2viXnID7YCLMaO5qIdPtsFhcbS+Zceq5NUWuDfVF rGJ1S7RWwwTgJ6gI0xCsyxlfGAjFEdgdJOrkIUtuHhTGknrd1DE7e9rEhHeKmekInDOd hZpA== X-Gm-Message-State: APjAAAXLz6k+IF3YxgPaPr7P1r6PZdBT7B1uF5d/YVGs5L91m7UKk5AX pifc5qqeuWGfEyv/ADXj+u1XdpokdfJO8Y4BP39Dtdqom4k+vLAm0V8O0gGN/UglZY2obzifb4M KGrSEWKPgFoj8IjeQIolu7Z+x X-Received: by 2002:a17:902:322:: with SMTP id 31mr16947677pld.244.1575070369422; Fri, 29 Nov 2019 15:32:49 -0800 (PST) X-Google-Smtp-Source: APXvYqzVF8jKFmE3JjTqFteQwms+t8J+SNdGuKRwByDQQgQ8pgQWV7RRFncg5z+6xw+77cmd/+Z98Q== X-Received: by 2002:a17:902:322:: with SMTP id 31mr16947655pld.244.1575070369087; Fri, 29 Nov 2019 15:32:49 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id e1sm9545891pfl.98.2019.11.29.15.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 15:32:48 -0800 (PST) Date: Fri, 29 Nov 2019 16:32:47 -0700 From: Jerry Snitselaar To: Jarkko Sakkinen , Dan Williams , Linus Torvalds , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, James Morris , Stefan Berger , stable Subject: Re: [GIT PULL] tpmdd updates for Linux v5.4 Message-ID: <20191129233247.oavwmrp65b5nc5hq@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Jarkko Sakkinen , Dan Williams , Linus Torvalds , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, James Morris , Stefan Berger , stable References: <20190902143121.pjnykevzlajlcrh6@linux.intel.com> <20191122161836.ry3cbon2iy22ftoc@cantor> <20191129210400.GB12055@linux.intel.com> <20191129232249.bgj25rlwrcg3afj5@cantor> MIME-Version: 1.0 In-Reply-To: <20191129232249.bgj25rlwrcg3afj5@cantor> X-MC-Unique: q2QRIjVLOrmGeWpQ35DlJQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri Nov 29 19, Jerry Snitselaar wrote: >On Fri Nov 29 19, Jarkko Sakkinen wrote: >>On Fri, Nov 22, 2019 at 09:18:36AM -0700, Jerry Snitselaar wrote: >>>On Wed Nov 20 19, Dan Williams wrote: >>>> On Mon, Sep 2, 2019 at 7:34 AM Jarkko Sakkinen >>>> wrote: >>>> > >>>> > Hi >>>> > >>>> > A new driver for fTPM living inside ARM TEE was added this round. In >>>> > addition to that, there is three bug fixes and one clean up. >>>> > >>>> > /Jarkko >>>> > >>>> > The following changes since commit 8fb8e9e46261e0117cb3cffb6dd8bb7e0= 8f8649b: >>>> > >>>> > Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel= /git/rdma/rdma (2019-08-30 09:23:45 -0700) >>>> > >>>> > are available in the Git repository at: >>>> > >>>> > git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-= 20190902 >>>> > >>>> > for you to fetch changes up to e8bd417aab0c72bfb54465596b16085702ba0= 405: >>>> > >>>> > tpm/tpm_ftpm_tee: Document fTPM TEE driver (2019-09-02 17:08:35 +0= 300) >>>> > >>>> > ---------------------------------------------------------------- >>>> > tpmdd updates for Linux v5.4 >>>> > >>>> > ---------------------------------------------------------------- >>>> > Jarkko Sakkinen (1): >>>> > tpm: Remove a deprecated comments about implicit sysfs locking >>>> > >>>> > Lukas Bulwahn (1): >>>> > MAINTAINERS: fix style in KEYS-TRUSTED entry >>>> > >>>> > Sasha Levin (2): >>>> > tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE >>>> > tpm/tpm_ftpm_tee: Document fTPM TEE driver >>>> > >>>> > Stefan Berger (2): >>>> > tpm_tis_core: Turn on the TPM before probing IRQ's >>>> > tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interru= pts >>>> >>>> Hi Jarrko, >>>> >>>> I'm replying here because I can't find the patches to reply to >>>> directly from LKML. >>>> >>>> Commit 7f064c378e2c "tpm_tis_core: Turn on the TPM before probing >>>> IRQ's" in the v5.3-stable tree caused a regression on a pre-release >>>> platform with a TPM2 device. The interrupt starts screaming when the >>>> driver is loaded and does not stop until the device is force unbond >>>> from the driver by: >>>> >>>> echo IFX0740:00 > /sys/bus/platform/drivers/tpm_tis/unbind >>>> >>>> I checked v5.4-rc8 and it has the same problem. I tried reverting: >>>> >>>> 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for in= terrupts >>>> 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's >>>> >>>> Which silenced the screaming interrupt problem, but now the TPM is rep= orting: >>>> >>>> [ 3.725131] tpm_tis IFX0740:00: 2.0 TPM (device-id 0x1B, rev-id 16) >>>> [ 3.725358] tpm tpm0: tpm_try_transmit: send(): error -5 >>>> [ 3.725359] tpm tpm0: [Firmware Bug]: TPM interrupt not working, >>>> polling instead >>>> >>>> ...at load, where it was not reporting this previously. Can you take a= look? >>>> >>> >>>We've had an issue reported for a Lenovo t490s getting an interrupt stor= m >>>with the Fedora 5.3 stable kernel, so it appears to be impacting a numbe= r of >>>systems. >> >>Hi sorry for inactivity. I've had a renovation going on where I live >>which has caused some crackling in the comms but I'm catching up during >>the weekend. >> >>Which CPU model does T490S have? Can you paste /proc/cpuinfo? >> >>/Jarkko >> > >I still don't have access to one of the laptops, but looking online >they should have one of the following: i5-8265U, i5-8365U, i7-8565U, >or i7-8665U. The tpm is discrete, so I don't know that the cpu will >matter. Looking at a log, in the t490s case it is an STMicroelectronics >chip. So both Infineon and STM so far. > In the case reported on Fedora the cpu is a i7-8665U.