From: Stefan Schaeckeler <schaecsn@gmx.net>
To: rui.zhang@intel.com, edubezval@gmail.com,
daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
heiko@sntech.de, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: rockchip: enable hwmon
Date: Mon, 2 Dec 2019 06:52:56 -0800 (PST) [thread overview]
Message-ID: <20191202145256.78AA06E85603@corona.crabdance.com> (raw)
In-Reply-To: <20191118052413.D729B6E85603@corona.crabdance.com> (message from schaecsn on Sun, 17 Nov 2019 21:24:13 -0800 (PST))
Hello linux power management mailing list and others,
New month, new try. Could someone review this patch, please. I would really
like to see the Rockchip RK3399 temperature sensors hooked up to the hwmon API.
~ Stefan
> Enable hwmon for the soc and gpu temperature sensors.
>
> Signed-off-by: Stefan Schaeckeler <schaecsn@gmx.net>
>
> ---
> drivers/thermal/rockchip_thermal.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 343c2f5c5a25..e47c60010259 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -19,6 +19,8 @@
> #include <linux/mfd/syscon.h>
> #include <linux/pinctrl/consumer.h>
>
> +#include "thermal_hwmon.h"
> +
> /**
> * If the temperature over a period of time High,
> * the resulting TSHUT gave CRU module,let it reset the entire chip,
> @@ -1321,8 +1323,15 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
>
> thermal->chip->control(thermal->regs, true);
>
> - for (i = 0; i < thermal->chip->chn_num; i++)
> + for (i = 0; i < thermal->chip->chn_num; i++) {
> rockchip_thermal_toggle_sensor(&thermal->sensors[i], true);
> + thermal->sensors[i].tzd->tzp->no_hwmon = false;
> + error = thermal_add_hwmon_sysfs(thermal->sensors[i].tzd);
> + if (error)
> + dev_warn(&pdev->dev,
> + "failed to register sensor %d with hwmon: %d\n",
> + i, error);
> + }
>
> platform_set_drvdata(pdev, thermal);
>
> @@ -1344,6 +1353,7 @@ static int rockchip_thermal_remove(struct platform_device *pdev)
> for (i = 0; i < thermal->chip->chn_num; i++) {
> struct rockchip_thermal_sensor *sensor = &thermal->sensors[i];
>
> + thermal_remove_hwmon_sysfs(sensor->tzd);
> rockchip_thermal_toggle_sensor(sensor, false);
> }
>
> --
> 2.24.0
>
next prev parent reply other threads:[~2019-12-02 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 5:24 [PATCH] thermal: rockchip: enable hwmon schaecsn
2019-12-02 14:52 ` Stefan Schaeckeler [this message]
2019-12-09 17:08 ` Daniel Lezcano
2019-12-17 5:23 Chen-Yu Tsai
2019-12-17 8:01 ` Daniel Lezcano
2019-12-17 8:02 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202145256.78AA06E85603@corona.crabdance.com \
--to=schaecsn@gmx.net \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).