From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5B7C432C0 for ; Mon, 2 Dec 2019 23:30:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F067620684 for ; Mon, 2 Dec 2019 23:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbfLBXaw (ORCPT ); Mon, 2 Dec 2019 18:30:52 -0500 Received: from mga07.intel.com ([134.134.136.100]:14390 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLBXaw (ORCPT ); Mon, 2 Dec 2019 18:30:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 15:30:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,270,1571727600"; d="scan'208";a="222612595" Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by orsmga002.jf.intel.com with ESMTP; 02 Dec 2019 15:30:51 -0800 Date: Mon, 2 Dec 2019 15:42:44 -0800 From: Fenghua Yu To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , H Peter Anvin , Tony Luck , Reinette Chatre , Babu Moger , Andre Przywara , Sai Praneeth Prakhya , Ravi V Shankar , linux-kernel , x86 Subject: Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests Message-ID: <20191202234244.GC220960@romley-ivt3.sc.intel.com> References: <1574901584-212957-1-git-send-email-fenghua.yu@intel.com> <1574901584-212957-2-git-send-email-fenghua.yu@intel.com> <20191128072338.GA17745@zn.tnic> <20191202185334.GA220960@romley-ivt3.sc.intel.com> <20191202230642.GD32696@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202230642.GD32696@zn.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 03, 2019 at 12:06:42AM +0100, Borislav Petkov wrote: > On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote: > > Babu's major contributions are in v5 where he virtually touched every > > patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch: > > https://lore.kernel.org/patchwork/cover/1033532/ > > > > That's why I keep his SOB in v6-v8 in each patch. > > For that you either need to use > > Co-developed-by: Babu > > or state the fact that Babu did contribute to the patches in freetext in > the commit messages. > > As it is now, it is not clear what it means. You could've kept the order > from v5 since you took his submission and could've done: > > Signed-off-by: Fenghua Yu > Signed-off-by: Babu Moger > Signed-off-by: Fenghua Yu > > to show you're the author, Babu handled them further and you're sending > the patchset now, but the other thing I suggested above is more clear > IMO. Ok. I will add Co-developed-by: Babu in the patches. Should I send v9 patch set with only the Co-developed-by changes? Thanks. -Fenghua