linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf probe -d failing to delete probes
Date: Tue, 3 Dec 2019 07:18:54 +0900	[thread overview]
Message-ID: <20191203071854.37e20e0455626f5c388b3cf3@kernel.org> (raw)
In-Reply-To: <20191202190452.GI4063@kernel.org>

Hi Arnaldo,

On Mon, 2 Dec 2019 16:04:52 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Mon, Dec 02, 2019 at 03:59:58PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Nov 29, 2019 at 12:13:24PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > 
> > > Hi Masami,
> > > 
> > >    Can you please take a look at this?
> > > 
> > > [root@quaco perf]# perf probe -l
> > >   probe_perf:map__map_ip (on ui__warn_map_erange+222@perf/tools/perf/builtin-top.c in /home/acme/bin/perf)
> > >   probe_perf:map__map_ip (on ui__warn_map_erange+222@perf/tools/perf/builtin-top.c in /home/acme/bin/perf)
> > >   probe_perf:map__map_ip (on perf_evlist__set_paused+222@util/evlist.c in /home/acme/bin/perf)
> > >   probe_perf:map__map_ip (on perf_evlist__resume+222@util/evlist.c in /home/acme/bin/perf)
> > >   probe_perf:map__map_ip (on perf_evsel__group_desc+222@util/evsel.c in /home/acme/bin/perf)
> > >   probe_perf:map__map_ip (on svg_partial_wakeline+222@util/svghelper.c in /home/acme/bin/perf)
> > > [root@quaco perf]# perf probe -d probe_perf:map_*
> > > "probe_perf:map_*" does not hit any event.
> > >   Error: Failed to delete events.
> > > [root@quaco perf]# perf probe -d probe_perf:*
> > > "probe_perf:*" does not hit any event.
> > >   Error: Failed to delete events.
> > > [root@quaco perf]# perf probe -d probe*:*
> > > "probe*:*" does not hit any event.
> > >   Error: Failed to delete events.
> > > [root@quaco perf]# perf probe -d '*:*'
> > > "*:*" does not hit any event.
> > >   Error: Failed to delete events.
> > > [root@quaco perf]#
> > 
> > [root@quaco ~]# perf probe -l
> >   probe_perf:map__map_ip (on process_sample_event+6663@tools/perf/builtin-script.c in /home/acme/bin/perf)
> >   probe_perf:map__map_ip (on process_sample_event+6739@tools/perf/builtin-script.c in /home/acme/bin/perf)
> >   probe_perf:map__map_ip (on unwind_entry+436@util/machine.c in /home/acme/bin/perf)
> >   probe_perf:map__map_ip (on machine__process_extra_kernel_map+31@util/machine.c in /home/acme/bin/perf)
> >   probe_perf:map__map_ip (on __maps__insert+192@util/map.c in /home/acme/bin/perf)
> >   probe_perf:map__map_ip (on dso__process_kernel_symbol+336@util/symbol-elf.c in /home/acme/bin/perf)
> > [root@quaco ~]# ls -la /sys/kernel/debug/tracing/events/probe_perf/
> > total 0
> > drwxr-xr-x.   3 root root 0 Nov 29 12:09 .
> > drwxr-xr-x. 113 root root 0 Dec  2 15:56 ..
> > -rw-r--r--.   1 root root 0 Nov 29 12:09 enable
> > -rw-r--r--.   1 root root 0 Nov 29 12:09 filter
> > drwxr-xr-x.   2 root root 0 Nov 29 12:09 map__map_ip
> > [root@quaco ~]#
> > 
> > Trying to figure out how to remove it via debugfs/tracefs
> 
> [root@quaco ~]# cat /sys/kernel/debug/tracing/dynamic_events
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x000000000005f257
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x000000000005f2a3
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x00000000000fda24
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x00000000000fdacf
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x00000000001028d0
> p:probe_perf/map__map_ip /home/acme/bin/perf:0x000000000016dd90
> [root@quaco ~]#
> 
> [root@quaco ~]# cat /sys/kernel/debug/tracing/kprobe_events
> [root@quaco ~]#
> 
> [root@quaco ~]# echo > /sys/kernel/debug/tracing/kprobe_events
> [root@quaco ~]# perf probe -l
>   probe_perf:map__map_ip (on process_sample_event+6663@tools/perf/builtin-script.c in /home/acme/bin/perf)
>   probe_perf:map__map_ip (on process_sample_event+6739@tools/perf/builtin-script.c in /home/acme/bin/perf)
>   probe_perf:map__map_ip (on unwind_entry+436@util/machine.c in /home/acme/bin/perf)
>   probe_perf:map__map_ip (on machine__process_extra_kernel_map+31@util/machine.c in /home/acme/bin/perf)
>   probe_perf:map__map_ip (on __maps__insert+192@util/map.c in /home/acme/bin/perf)
>   probe_perf:map__map_ip (on dso__process_kernel_symbol+336@util/symbol-elf.c in /home/acme/bin/perf)
> [root@quaco ~]#
> 
> Finally it works:
> 
> [root@quaco ~]# echo > /sys/kernel/debug/tracing/dynamic_events
> [root@quaco ~]# cat /sys/kernel/debug/tracing/dynamic_events
> [root@quaco ~]#
> [root@quaco ~]# perf probe -l
> [root@quaco ~]#
> 
> A workaround, now to find out why 'perf probe -d '*:*' and the other
> reported variants are failing...
> 

Thank you for pointing it out. You can use '*' instead of '*:*' to list them all.
Anyway, there seems an inssue when I introduced multiprobe support.
I'll fix it soon.

Thanks,

> - Arnaldo


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2019-12-02 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 15:13 perf probe -d failing to delete probes Arnaldo Carvalho de Melo
2019-12-02 18:59 ` Arnaldo Carvalho de Melo
2019-12-02 19:04   ` Arnaldo Carvalho de Melo
2019-12-02 22:18     ` Masami Hiramatsu [this message]
2019-12-03  0:55       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203071854.37e20e0455626f5c388b3cf3@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).