From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171C9C432C0 for ; Tue, 3 Dec 2019 22:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC70D2073C for ; Tue, 3 Dec 2019 22:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412768; bh=yPoiiB8nW+V4aZlHFa+hH08rvxh+w9pWkK2I9swro+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yObPdbx7LKp6IXlmNWov+28sumKIszWE6qwuY7V6tI7dch7Nmj6LL3RO/05aRnDap nlv1X5UJXyOjdv9j2R4muf1fSKlJTU+IAMJvpsZZ2B7f4W2ebJqOn3EgyJ+mLaO/gq oUkXjU3Sm7ou7u6VbEgpZysvqmwryflROR37+o5k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728218AbfLCWj1 (ORCPT ); Tue, 3 Dec 2019 17:39:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:49492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727872AbfLCWjX (ORCPT ); Tue, 3 Dec 2019 17:39:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF16F207DD; Tue, 3 Dec 2019 22:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412763; bh=yPoiiB8nW+V4aZlHFa+hH08rvxh+w9pWkK2I9swro+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SFVV8yKizovC3i7sK/1WRWcvD0izFZ4m8q6gGb2Ogg8Nnf1HFKftcBf5z5+ZjEW2I Uh9Au1BasDDY7yXmqpaW+XdJsAIYM+wRY5HkiD3bXr4aVplaySXeGXluYm+HsrS1JB E1XYPX9/4e1uXBUfWjlWySvW6oPZq6yRlbUUs4+0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Dan Carpenter Subject: [PATCH 5.4 08/46] staging: rtl8192e: fix potential use after free Date: Tue, 3 Dec 2019 23:35:28 +0100 Message-Id: <20191203212722.065206368@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203212705.175425505@linuxfoundation.org> References: <20191203212705.175425505@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian commit b7aa39a2ed0112d07fc277ebd24a08a7b2368ab9 upstream. The variable skb is released via kfree_skb() when the return value of _rtl92e_tx is not zero. However, after that, skb is accessed again to read its length, which may result in a use after free bug. This patch fixes the bug by moving the release operation to where skb is never used later. Signed-off-by: Pan Bian Reviewed-by: Dan Carpenter Cc: stable Link: https://lore.kernel.org/r/1572965351-6745-1-git-send-email-bianpan2016@163.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1616,14 +1616,15 @@ static void _rtl92e_hard_data_xmit(struc memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); skb_push(skb, priv->rtllib->tx_headroom); ret = _rtl92e_tx(dev, skb); - if (ret != 0) - kfree_skb(skb); if (queue_index != MGNT_QUEUE) { priv->rtllib->stats.tx_bytes += (skb->len - priv->rtllib->tx_headroom); priv->rtllib->stats.tx_packets++; } + + if (ret != 0) + kfree_skb(skb); } static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)