From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91A8C432C0 for ; Tue, 3 Dec 2019 22:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 894C720684 for ; Tue, 3 Dec 2019 22:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412695; bh=V7L122m0JCzG3CnlKLZqRrIIAH7E7YKziM47LY8R0HQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zBGFzZ/V7V70NNHOVxfodKLCMl8zUuH7SXV15WUYThyNndIYF5M3Y3U6JV6xtTyKa xktSFbx555uoNDRhV/H1j81L18WKDuidfrB2FCBh4crvP/lQxuL17XcBqJuXLodqxy fHKvyvZr22a/TxtU9RRzviw8Zd4zko1QeoGE6YGo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbfLCWiN (ORCPT ); Tue, 3 Dec 2019 17:38:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:47004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbfLCWiK (ORCPT ); Tue, 3 Dec 2019 17:38:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E01FC20684; Tue, 3 Dec 2019 22:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412690; bh=V7L122m0JCzG3CnlKLZqRrIIAH7E7YKziM47LY8R0HQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aNAns0xYdf8sVoAAR+lufx6NlZ9PHsgmvVNO2UY/GZvw7yYQBpuoJfgBlOM6WZvIA yo9Tk/GfG85zfYyW9bTgolwPfVmgv7YEKuEH58g7fERR/u2hB7tc/FGpUfPjpfzqpe gd7yxQj4Hh3UpEqEqlFxzfJvuhGmQldlTitE+sok= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Abeni , "David S. Miller" Subject: [PATCH 5.4 27/46] openvswitch: drop unneeded BUG_ON() in ovs_flow_cmd_build_info() Date: Tue, 3 Dec 2019 23:35:47 +0100 Message-Id: <20191203212742.616954608@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203212705.175425505@linuxfoundation.org> References: <20191203212705.175425505@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Abeni [ Upstream commit 8ffeb03fbba3b599690b361467bfd2373e8c450f ] All the callers of ovs_flow_cmd_build_info() already deal with error return code correctly, so we can handle the error condition in a more gracefull way. Still dump a warning to preserve debuggability. v1 -> v2: - clarify the commit message - clean the skb and report the error (DaveM) Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.") Signed-off-by: Paolo Abeni Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/openvswitch/datapath.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -886,7 +886,10 @@ static struct sk_buff *ovs_flow_cmd_buil retval = ovs_flow_cmd_fill_info(flow, dp_ifindex, skb, info->snd_portid, info->snd_seq, 0, cmd, ufid_flags); - BUG_ON(retval < 0); + if (WARN_ON_ONCE(retval < 0)) { + kfree_skb(skb); + skb = ERR_PTR(retval); + } return skb; }