From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED59C432C0 for ; Tue, 3 Dec 2019 23:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4E1D2064B for ; Tue, 3 Dec 2019 23:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575414592; bh=HoAFqpYfa74MQHwNePRBAUOnqHPBhxifuXH9ekCuqMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qNCu1OHTv/dvKjNc7zm0TG/U1kAtXP9xl79P9HbfbAfYe/iHIllOUB0vLBTJ+3lOy 2L6qQPbcNSi3nbR9/CBtzOc467aFEDA3uzEr+ZBnInTMi7QnryuvpGAOkHVtXHcPHd vnCWRs1gYja1OkgrF+PlFUe0OvvjuxOXKTfJsCIo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729083AbfLCXJv (ORCPT ); Tue, 3 Dec 2019 18:09:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:58902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728260AbfLCWn1 (ORCPT ); Tue, 3 Dec 2019 17:43:27 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B12EA20803; Tue, 3 Dec 2019 22:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413007; bh=HoAFqpYfa74MQHwNePRBAUOnqHPBhxifuXH9ekCuqMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i3KNQiatbK7zUNYFyu+w+1r6LFutrWKBYdZSZWZWFn/e0roBozFnYUXmPxscr+1dV OZVDVuKB0Ds/P//om9gETwSR8IroWZAxr1XM4lUZxqZtbTpQK3x9R2xB83zu4Q1IJ0 8bZNfe0RRv2SjYKrkO7f11yi6FyxRRxwF67t3AjI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, changzhu , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Sasha Levin Subject: [PATCH 5.3 083/135] drm/amdgpu: add warning for GRBM 1-cycle delay issue in gfx9 Date: Tue, 3 Dec 2019 23:35:23 +0100 Message-Id: <20191203213032.716189710@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203213005.828543156@linuxfoundation.org> References: <20191203213005.828543156@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: changzhu [ Upstream commit 440a7a54e7ec012ec8b27c27e460dfd6f9a24ddb ] It needs to add warning to update firmware in gfx9 in case that firmware is too old to have function to realize dummy read in cp firmware. Signed-off-by: changzhu Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 75faa56f243a4..b1388d3e72f74 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c @@ -538,6 +538,13 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev) adev->gfx.me_fw_write_wait = false; adev->gfx.mec_fw_write_wait = false; + if ((adev->gfx.mec_fw_version < 0x000001a5) || + (adev->gfx.mec_feature_version < 46) || + (adev->gfx.pfp_fw_version < 0x000000b7) || + (adev->gfx.pfp_feature_version < 46)) + DRM_WARN_ONCE("Warning: check cp_fw_version and update it to realize \ + GRBM requires 1-cycle delay in cp firmware\n"); + switch (adev->asic_type) { case CHIP_VEGA10: if ((adev->gfx.me_fw_version >= 0x0000009c) && -- 2.20.1