From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647D6C432C0 for ; Tue, 3 Dec 2019 22:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A7B820803 for ; Tue, 3 Dec 2019 22:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413005; bh=klQsIEaLdkvQn9mXHsL/19l5ID92BD8wx7KpDUk+fkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BTdJUT1WAaDjRaaLzHyngIPKld/yS0xQC2GwCYMO1FLSqOyxoaJNqCGVozn/eUHvo 3IjUz8LLy4FcCRsm35HtQi4abQCucFCZ2Rquob+ZeQ6IKaY5mz94fpJDzVlMYwzfH7 yqy0gtRJQwC2wyDrQloxBDmF961yhWAxYKU/of30= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728634AbfLCWnX (ORCPT ); Tue, 3 Dec 2019 17:43:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:58734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728621AbfLCWnU (ORCPT ); Tue, 3 Dec 2019 17:43:20 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19D242080F; Tue, 3 Dec 2019 22:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412999; bh=klQsIEaLdkvQn9mXHsL/19l5ID92BD8wx7KpDUk+fkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mJdGdmIGRz3oLROk0L33hn8gQ8wGsx4+ziLVN0kqTRBdrP7pd+c12nvxaqS1Ew+CT TPlaDKtZCT4TFGXJEbtt1bdKe5sN4xNzNfkneSmPGO3VDLOPO1bj6DqWInainGR3yB ZhLjCOggbdaYksopKfkGK9eYso9a47O9CIjLPHgE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mathias Kresin , Felipe Balbi Subject: [PATCH 5.3 098/135] usb: dwc2: use a longer core rest timeout in dwc2_core_reset() Date: Tue, 3 Dec 2019 23:35:38 +0100 Message-Id: <20191203213038.401637058@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203213005.828543156@linuxfoundation.org> References: <20191203213005.828543156@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathias Kresin commit 6689f0f4bb14e50917ba42eb9b41c25e0184970c upstream. Testing on different generations of Lantiq MIPS SoC based boards, showed that it takes up to 1500 us until the core reset bit is cleared. The driver from the vendor SDK (ifxhcd) uses a 1 second timeout. Use the same timeout to fix wrong hang detections and make the driver work for Lantiq MIPS SoCs. At least till kernel 4.14 the hanging reset only caused a warning but the driver was probed successful. With kernel 4.19 errors out with EBUSY. Cc: linux-stable # 4.19+ Signed-off-by: Mathias Kresin Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -524,7 +524,7 @@ int dwc2_core_reset(struct dwc2_hsotg *h greset |= GRSTCTL_CSFTRST; dwc2_writel(hsotg, greset, GRSTCTL); - if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_CSFTRST, 50)) { + if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_CSFTRST, 10000)) { dev_warn(hsotg->dev, "%s: HANG! Soft Reset timeout GRSTCTL GRSTCTL_CSFTRST\n", __func__); return -EBUSY;