From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C881C432C0 for ; Tue, 3 Dec 2019 22:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 649A62080F for ; Tue, 3 Dec 2019 22:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413204; bh=9JYLrUUpM0aBZhoAx+R07YXaj7ac/jBYho1RxIWZO7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=E/gkKMelxVlKc/+jdmH9+7I2yD6qr3XfAADoi6OZjQkNQxyrRSZkzJVVnfXL/uqYo PB9POHpzkuqTl/gogKzN4vdskxNBNMERgNB/sKi/tzB5bZ+s1QngfmDHxFF/5zF3v0 IQmdA9W/HrmiME57AFE8R1ebI6uBB+FvDaqQvLgk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729230AbfLCWqn (ORCPT ); Tue, 3 Dec 2019 17:46:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:36410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbfLCWqi (ORCPT ); Tue, 3 Dec 2019 17:46:38 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 880D420684; Tue, 3 Dec 2019 22:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413198; bh=9JYLrUUpM0aBZhoAx+R07YXaj7ac/jBYho1RxIWZO7c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bN9Pg7reBYyhH09h6GssUZHZlm7lVfWrwcdpwDxNYQUnPDL2phvf8UAeNqfD/i5Rg w9gvM6/TUtsbR+vX0D+MMrBs9WywMetZtE225jWxjuYCfvqgZIEwt6wik6mu+9AH0g zTuelXdnMeWqHYUYfVuxnlpvJIY8lapfdOx1mDd8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Timo=20Schl=C3=BC=C3=9Fler?= , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 4.19 035/321] can: mcp251x: mcp251x_restart_work_handler(): Fix potential force_quit race condition Date: Tue, 3 Dec 2019 23:31:41 +0100 Message-Id: <20191203223428.940510843@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Timo Schlüßler [ Upstream commit 27a0e54bae09d2dd023a01254db506d61cc50ba1 ] In mcp251x_restart_work_handler() the variable to stop the interrupt handler (priv->force_quit) is reset after the chip is restarted and thus a interrupt might occur. This patch fixes the potential race condition by resetting force_quit before enabling interrupts. Signed-off-by: Timo Schlüßler Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/spi/mcp251x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index de8d9dceb1236..0b0dd3f096dc6 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -773,6 +773,7 @@ static void mcp251x_restart_work_handler(struct work_struct *ws) if (priv->after_suspend) { mcp251x_hw_reset(spi); mcp251x_setup(net, spi); + priv->force_quit = 0; if (priv->after_suspend & AFTER_SUSPEND_RESTART) { mcp251x_set_normal_mode(spi); } else if (priv->after_suspend & AFTER_SUSPEND_UP) { @@ -784,7 +785,6 @@ static void mcp251x_restart_work_handler(struct work_struct *ws) mcp251x_hw_sleep(spi); } priv->after_suspend = 0; - priv->force_quit = 0; } if (priv->restart_tx) { -- 2.20.1