From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F4DC432C0 for ; Tue, 3 Dec 2019 23:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3435E2084B for ; Tue, 3 Dec 2019 23:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575414069; bh=klQsIEaLdkvQn9mXHsL/19l5ID92BD8wx7KpDUk+fkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PgakzDU+c0BOLNa7l9SPA7dL+pMDVIOWawqgF47QfOzSpXl+LMw2Ub3iwAnTJlS+H kQMhf+esL7fq/4g+ODIORt/2x8kHQGGDTq7QxU+4jnRi1Wj9ErQfOshsMwT/uOd7dU s/R7swh7ksoTQEYnBq+blCnpFpBzL6H16hCiwFVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730605AbfLCXBH (ORCPT ); Tue, 3 Dec 2019 18:01:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:51870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729231AbfLCW4l (ORCPT ); Tue, 3 Dec 2019 17:56:41 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F82320803; Tue, 3 Dec 2019 22:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413801; bh=klQsIEaLdkvQn9mXHsL/19l5ID92BD8wx7KpDUk+fkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b84PSBlyXmiVIikg0oGPW1gteEYDvWzMwx2HVEin+7pYHSda0OmwcZhZZZ782clG0 WI6DFpTybzFju9HaiNWf/R32LfzpY7tNDNaawvRi+DyzWIZ2CnVUIA9M2ZpID1xfjx oIi0PUSaqXgxdrEbI/nHPtMNcZ+qMwaxFl/dLMik= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mathias Kresin , Felipe Balbi Subject: [PATCH 4.19 268/321] usb: dwc2: use a longer core rest timeout in dwc2_core_reset() Date: Tue, 3 Dec 2019 23:35:34 +0100 Message-Id: <20191203223441.067373492@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathias Kresin commit 6689f0f4bb14e50917ba42eb9b41c25e0184970c upstream. Testing on different generations of Lantiq MIPS SoC based boards, showed that it takes up to 1500 us until the core reset bit is cleared. The driver from the vendor SDK (ifxhcd) uses a 1 second timeout. Use the same timeout to fix wrong hang detections and make the driver work for Lantiq MIPS SoCs. At least till kernel 4.14 the hanging reset only caused a warning but the driver was probed successful. With kernel 4.19 errors out with EBUSY. Cc: linux-stable # 4.19+ Signed-off-by: Mathias Kresin Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -524,7 +524,7 @@ int dwc2_core_reset(struct dwc2_hsotg *h greset |= GRSTCTL_CSFTRST; dwc2_writel(hsotg, greset, GRSTCTL); - if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_CSFTRST, 50)) { + if (dwc2_hsotg_wait_bit_clear(hsotg, GRSTCTL, GRSTCTL_CSFTRST, 10000)) { dev_warn(hsotg->dev, "%s: HANG! Soft Reset timeout GRSTCTL GRSTCTL_CSFTRST\n", __func__); return -EBUSY;