From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93603C432C0 for ; Tue, 3 Dec 2019 22:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D11F2053B for ; Tue, 3 Dec 2019 22:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413971; bh=Yt7MeVL/h89vHQ3EdAWoNy1Iz3N+bvLPZVujGOMb+sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CPCGFbVEO+0i2LL5HLJCn75TkzO1GktMPENbCGVHiZmBW+YaHpFrKGiWyVpx1PhMM /he50dsarWFfNT+yUujuWX3JPJD8mPnPAju/kzCGpxKppEofkjKX0OMETqChi6nCtG rdW0neF3YcysdkQbm3zdkM6TQ0kt4Rhd7NuzKFAI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730427AbfLCW7a (ORCPT ); Tue, 3 Dec 2019 17:59:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:55938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730463AbfLCW7T (ORCPT ); Tue, 3 Dec 2019 17:59:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 450BD2053B; Tue, 3 Dec 2019 22:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413958; bh=Yt7MeVL/h89vHQ3EdAWoNy1Iz3N+bvLPZVujGOMb+sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EV0UfkmhmcVA+OSXbhMj8+ybDUaMFS2LkN9dmorHdBsm5GZQ/S0sJvfKbJPjpDM6d 6rmv74G8ZxdETPTamQFnzmURrynHv3kEayYBvBmcAarRK29q+621niWK3q1o8HcsIG ee8NiCSO8NJJ+onN1Hj+1GqgrVqHeEHthOf6AqUU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lionel Debieve , Herbert Xu , Mathieu Poirier Subject: [PATCH 4.19 305/321] crypto: stm32/hash - Fix hmac issue more than 256 bytes Date: Tue, 3 Dec 2019 23:36:11 +0100 Message-Id: <20191203223443.014386583@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lionel Debieve commit 0acabecebc912b3ba06289e4ef40476acc499a37 upstream. Correct condition for the second hmac loop. Key must be only set in the first loop. Initial condition was wrong, HMAC_KEY flag was not properly checked. Signed-off-by: Lionel Debieve Signed-off-by: Herbert Xu Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/stm32/stm32-hash.c +++ b/drivers/crypto/stm32/stm32-hash.c @@ -365,7 +365,7 @@ static int stm32_hash_xmit_cpu(struct st return -ETIMEDOUT; if ((hdev->flags & HASH_FLAGS_HMAC) && - (hdev->flags & ~HASH_FLAGS_HMAC_KEY)) { + (!(hdev->flags & HASH_FLAGS_HMAC_KEY))) { hdev->flags |= HASH_FLAGS_HMAC_KEY; stm32_hash_write_key(hdev); if (stm32_hash_wait_busy(hdev))