From: Valentin Vidic <vvidic@valentin-vidic.from.hr>
To: Boris Pismenny <borisp@mellanox.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
John Fastabend <john.fastabend@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Valentin Vidic <vvidic@valentin-vidic.from.hr>
Subject: [PATCH] net/tls: Fix return values for setsockopt
Date: Tue, 3 Dec 2019 23:44:58 +0100 [thread overview]
Message-ID: <20191203224458.24338-1-vvidic@valentin-vidic.from.hr> (raw)
ENOTSUPP is not available in userspace:
setsockopt failed, 524, Unknown error 524
Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr>
---
net/tls/tls_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
index bdca31ffe6da..5830b8e02a36 100644
--- a/net/tls/tls_main.c
+++ b/net/tls/tls_main.c
@@ -496,7 +496,7 @@ static int do_tls_setsockopt_conf(struct sock *sk, char __user *optval,
/* check version */
if (crypto_info->version != TLS_1_2_VERSION &&
crypto_info->version != TLS_1_3_VERSION) {
- rc = -ENOTSUPP;
+ rc = -EINVAL;
goto err_crypto_info;
}
@@ -723,7 +723,7 @@ static int tls_init(struct sock *sk)
* share the ulp context.
*/
if (sk->sk_state != TCP_ESTABLISHED)
- return -ENOTSUPP;
+ return -ENOTCONN;
/* allocate tls context */
write_lock_bh(&sk->sk_callback_lock);
--
2.20.1
next reply other threads:[~2019-12-03 23:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 22:44 Valentin Vidic [this message]
2019-12-03 22:55 ` [PATCH] net/tls: Fix return values for setsockopt Jakub Kicinski
2019-12-04 18:29 ` [PATCH v2] " Valentin Vidic
2019-12-04 19:22 ` [PATCH] " Willem de Bruijn
2019-12-04 19:35 ` Jakub Kicinski
2019-12-04 20:43 ` Willem de Bruijn
2019-12-04 20:51 ` David Miller
2019-12-04 23:01 ` Jakub Kicinski
2019-12-05 0:55 ` David Miller
2019-12-05 6:41 ` [PATCH v3] net/tls: Fix return values to avoid ENOTSUPP Valentin Vidic
2019-12-05 19:34 ` Jakub Kicinski
2019-12-05 20:06 ` Willem de Bruijn
2019-12-05 20:43 ` Valentin Vidić
2019-12-05 20:45 ` Jakub Kicinski
2019-12-05 21:26 ` Willem de Bruijn
2019-12-05 23:08 ` Valentin Vidić
2019-12-07 4:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203224458.24338-1-vvidic@valentin-vidic.from.hr \
--to=vvidic@valentin-vidic.from.hr \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).