From: David Miller <davem@davemloft.net>
To: aconole@redhat.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, dev@openvswitch.org,
linux-kernel@vger.kernel.org, mleitner@redhat.com,
paulb@mellanox.com, roid@mellanox.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH 2/2] act_ct: support asymmetric conntrack
Date: Wed, 04 Dec 2019 16:33:48 -0800 (PST) [thread overview]
Message-ID: <20191204.163348.259023660348933654.davem@davemloft.net> (raw)
In-Reply-To: <20191203213414.24109-2-aconole@redhat.com>
From: Aaron Conole <aconole@redhat.com>
Date: Tue, 3 Dec 2019 16:34:14 -0500
> The act_ct TC module shares a common conntrack and NAT infrastructure
> exposed via netfilter. It's possible that a packet needs both SNAT and
> DNAT manipulation, due to e.g. tuple collision. Netfilter can support
> this because it runs through the NAT table twice - once on ingress and
> again after egress. The act_ct action doesn't have such capability.
>
> Like netfilter hook infrastructure, we should run through NAT twice to
> keep the symmetry.
>
> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> NOTE: this is a repost to see if the email client issues go away.
Applied and queued up for -stable.
Next time, please:
1) Provide an introductory posting ala "[PATCH net 0/N] ..." describing
what the patch series does on a high level, how it is doing it, and
why it is doing it that way.
This allows people to understand what they are about to read, and it
gives me a single mail to respon to when I apply your entire series.
2) Always clearly indicate the target GIT tree in your Subject line,
in these cases it should have been "[PATCH net N/M]"
Thank you.
next prev parent reply other threads:[~2019-12-05 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 21:34 [PATCH 1/2] openvswitch: support asymmetric conntrack Aaron Conole
2019-12-03 21:34 ` [PATCH 2/2] act_ct: " Aaron Conole
2019-12-05 0:33 ` David Miller [this message]
2019-12-05 0:32 ` [PATCH 1/2] openvswitch: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204.163348.259023660348933654.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aconole@redhat.com \
--cc=dev@openvswitch.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=paulb@mellanox.com \
--cc=pshelar@ovn.org \
--cc=roid@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).