archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <>
To: Colin King <>,
	Andrew Morton <>
Cc: Nitin Gupta <>,
	Sergey Senozhatsky <>,
	Jens Axboe <>,,,
Subject: Re: [PATCH] zram: fix error return codes not being returned in writeback_store
Date: Tue, 3 Dec 2019 17:16:28 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Nov 28, 2019 at 12:29:58PM +0000, Colin King wrote:
> From: Colin Ian King <>
> Currently when an error code -EIO or -ENOSPC in the for-loop of
> writeback_store the error code is being overwritten by a ret = len
> assignment at the end of the function and the error codes are being
> lost.  Fix this by assigning ret = len at the start of the function
> and remove the assignment from the end, hence allowing ret to be
> preserved when error codes are assigned to it.
> Addresses-Coverity: ("Unused value")
> Fixes: a939888ec38b ("zram: support idle/huge page writeback")
> Signed-off-by: Colin Ian King <>
Acked-by: Minchan Kim <>


      reply	other threads:[~2019-12-04  1:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28 12:29 Colin King
2019-12-04  1:16 ` Minchan Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] zram: fix error return codes not being returned in writeback_store' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).