From: Steven Rostedt <rostedt@goodmis.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Silence an uninitialized variable warning
Date: Wed, 4 Dec 2019 09:26:40 -0500 [thread overview]
Message-ID: <20191204092640.692c95af@gandalf.local.home> (raw)
In-Reply-To: <20191126121934.kuolgbm55dirfbay@kili.mountain>
On Tue, 26 Nov 2019 15:19:34 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch complains that "ret" could be uninitialized if we don't enter the
> loop. I don't know if that's possible, but it's nicer to return a
> literal zero instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> kernel/trace/trace_syscalls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 73140d80dd46..63528f458826 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -286,7 +286,7 @@ static int __init syscall_enter_define_fields(struct trace_event_call *call)
> offset += sizeof(unsigned long);
> }
>
> - return ret;
> + return 0;
> }
>
> static void ftrace_syscall_enter(void *data, struct pt_regs *regs, long id)
The current code has this:
static int __init syscall_enter_define_fields(struct trace_event_call *call)
{
struct syscall_trace_enter trace;
struct syscall_metadata *meta = call->data;
int ret;
int i;
int offset = offsetof(typeof(trace), args);
ret = trace_define_field(call, SYSCALL_FIELD(int, nr, __syscall_nr),
FILTER_OTHER);
if (ret)
return ret;
for (i = 0; i < meta->nb_args; i++) {
ret = trace_define_field(call, meta->types[i],
meta->args[i], offset,
sizeof(unsigned long), 0,
FILTER_OTHER);
offset += sizeof(unsigned long);
}
return ret;
}
How can ret possibly be uninitialized?
-- Steve
next prev parent reply other threads:[~2019-12-04 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:19 [PATCH] Silence an uninitialized variable warning Dan Carpenter
2019-12-04 14:26 ` Steven Rostedt [this message]
2019-12-04 18:42 ` Dan Carpenter
2019-12-05 9:32 ` Peter Zijlstra
2019-12-05 10:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204092640.692c95af@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).