From: Luis Henriques <lhenriques@suse.com>
To: Yanhu Cao <gmayyyha@gmail.com>
Cc: jlayton@kernel.org, sage@redhat.com, idryomov@gmail.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ceph: check set quota operation support before syncing setxattr.
Date: Wed, 4 Dec 2019 10:36:29 +0000 [thread overview]
Message-ID: <20191204103629.GA22244@hermes.olymp> (raw)
In-Reply-To: <20191204031005.2638-1-gmayyyha@gmail.com>
On Wed, Dec 04, 2019 at 11:10:05AM +0800, Yanhu Cao wrote:
> Environment
> -----------
> ceph version: 12.2.*
> kernel version: 4.19+
>
> setfattr quota operation actually sends op to MDS, and settings
> effective. but kclient outputs 'Operation not supported'. This may confuse
> users' understandings.
What exactly do you mean by "settings effective"? There have been
changes in the way CephFS quotas work in mimic and, if you're using a
Luminous cluster (12.2.*) the kernel client effectively does *not*
support quotas -- you'll be able to exceed the quotas you've tried to
set because the client won't be checking the limits. Thus, -EOPNOTSUPP
seems appropriate for this scenario.
I guess that the confusing part is that the xattr is actually set in
that case, but the kernel client won't be able to use it to validate
quotas in the filesystem tree because realms won't be created.
Cheers,
--
Luís
>
> If the kernel version and ceph version are not compatible, should check
> quota operations are supported first, then do sync_setxattr.
>
> reference: https://docs.ceph.com/docs/master/cephfs/quota/
>
> Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
> ---
> fs/ceph/xattr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index cb18ee637cb7..189aace75186 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -1132,8 +1132,8 @@ int __ceph_setxattr(struct inode *inode, const char *name,
> "during filling trace\n", inode);
> err = -EBUSY;
> } else {
> - err = ceph_sync_setxattr(inode, name, value, size, flags);
> - if (err >= 0 && check_realm) {
> + err = 0;
> + if (check_realm) {
> /* check if snaprealm was created for quota inode */
> spin_lock(&ci->i_ceph_lock);
> if ((ci->i_max_files || ci->i_max_bytes) &&
> @@ -1142,6 +1142,8 @@ int __ceph_setxattr(struct inode *inode, const char *name,
> err = -EOPNOTSUPP;
> spin_unlock(&ci->i_ceph_lock);
> }
> + if (err == 0)
> + err = ceph_sync_setxattr(inode, name, value, size, flags);
> }
> out:
> ceph_free_cap_flush(prealloc_cf);
> --
> 2.21.0 (Apple Git-122.2)
>
next prev parent reply other threads:[~2019-12-04 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 3:10 [PATCH] ceph: check set quota operation support before syncing setxattr Yanhu Cao
2019-12-04 10:36 ` Luis Henriques [this message]
2019-12-05 2:42 ` Yanhu Cao
2019-12-05 10:24 ` Luis Henriques
2019-12-09 2:13 ` Yanhu Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204103629.GA22244@hermes.olymp \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=gmayyyha@gmail.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).