linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: acme@kernel.org, kan.liang@intel.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, namhyung@kernel.org,
	ak@linux.intel.com, yao.jin@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] perf report: Few fixes
Date: Wed, 4 Dec 2019 13:07:07 +0100	[thread overview]
Message-ID: <20191204120707.GC20746@krava> (raw)
In-Reply-To: <20191114132213.5419-1-ravi.bangoria@linux.ibm.com>

On Thu, Nov 14, 2019 at 06:52:10PM +0530, Ravi Bangoria wrote:
> v1: https://lore.kernel.org/r/20191112054946.5869-1-ravi.bangoria@linux.ibm.com
> 
> v1 fixed a segfault when -F phys_daddr is used in perf report without
> --mem-mode. Arnaldo suggested to bail out the option completely in
> such case instead of showing 0 values.
> 
> Ravi Bangoria (3):
>   perf hists: Replace pr_err with ui__error
>   perf report: Make -F more strict like -s
>   perf report: Error out for mem mode fields if mem info is not
>     available
> 
>  tools/perf/builtin-report.c |  8 ++++++++
>  tools/perf/util/sort.c      | 16 +++++++++++-----
>  2 files changed, 19 insertions(+), 5 deletions(-)

looks good

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka


      parent reply	other threads:[~2019-12-04 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 13:22 [PATCH v2 0/3] perf report: Few fixes Ravi Bangoria
2019-11-14 13:22 ` [PATCH v2 1/3] perf hists: Replace pr_err with ui__error Ravi Bangoria
2019-12-04 15:26   ` Arnaldo Carvalho de Melo
2019-12-06  8:03   ` [tip: perf/urgent] perf report/top TUI: Replace pr_err() with ui__error() tip-bot2 for Ravi Bangoria
2019-11-14 13:22 ` [PATCH v2 2/3] perf report: Make -F more strict like -s Ravi Bangoria
2019-12-06  8:03   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2019-11-14 13:22 ` [PATCH v2 3/3] perf report: Bail out --mem-mode if mem info is not available Ravi Bangoria
2019-12-06  8:03   ` [tip: perf/urgent] " tip-bot2 for Ravi Bangoria
2019-12-04 10:36 ` [PATCH v2 0/3] perf report: Few fixes Ravi Bangoria
2019-12-04 12:07 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204120707.GC20746@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).