From: Peter Zijlstra <peterz@infradead.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Fenghua Yu' <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
Ashok Raj <ashok.raj@intel.com>, Tony Luck <tony.luck@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v2 1/4] drivers/net/b44: Change to non-atomic bit operations
Date: Wed, 4 Dec 2019 16:19:40 +0100 [thread overview]
Message-ID: <20191204151940.GY2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <7cbe0135c6234700bebdefd0fdaa4f6a@AcuMS.aculab.com>
On Tue, Nov 26, 2019 at 09:49:08AM +0000, David Laight wrote:
> > memset(ppattern + offset, 0xff, magicsync);
> > for (j = 0; j < magicsync; j++)
> > - set_bit(len++, (unsigned long *) pmask);
> > + __set_bit(len++, (unsigned long *)pmask);
>
> While this stops the misaligned locks, the code is still horribly borked on BE systems.
Quite so.
> The way pmask is used definitely wanst a u32[] not a u64[] one.
Not sure, the code seems fairly consistent in using u8[].
And I suppose we can write the above like:
pmask[len >> 3] |= BIT(len & 7); len++;
instead.
next prev parent reply other threads:[~2019-12-04 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 19:43 [PATCH v2 0/4] Fix some 4-byte vs. 8-byte alignment issues in atomic bit operations Fenghua Yu
2019-11-25 19:43 ` [PATCH v2 1/4] drivers/net/b44: Change to non-atomic " Fenghua Yu
2019-11-26 9:49 ` David Laight
2019-12-04 15:19 ` Peter Zijlstra [this message]
2019-11-25 19:43 ` [PATCH v2 2/4] xen-pcifront: Align address of flags to size of unsigned long Fenghua Yu
2019-11-26 9:53 ` David Laight
2019-11-26 10:02 ` Jürgen Groß
2019-12-02 18:28 ` Luck, Tony
2019-12-02 22:29 ` Fenghua Yu
2019-11-25 19:43 ` [PATCH v2 3/4] mtd: rawnand: fsmc: Change to non-atomic bit operations Fenghua Yu
2019-12-04 15:28 ` Peter Zijlstra
2019-11-25 19:43 ` [PATCH v2 4/4] x86/mce: Force alignment for atomic " Fenghua Yu
2019-11-26 10:13 ` [PATCH v2 0/4] Fix some 4-byte vs. 8-byte alignment issues in " David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204151940.GY2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@ACULAB.COM \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).