From: Rob Herring <robh@kernel.org>
To: Khouloud Touil <ktouil@baylibre.com>
Cc: bgolaszewski@baylibre.com, mark.rutland@arm.com,
srinivas.kandagatla@linaro.org, baylibre-upstreaming@groups.io,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH 3/4] dt-bindings: at24: remove the optional property write-protect-gpios
Date: Wed, 4 Dec 2019 09:22:36 -0600 [thread overview]
Message-ID: <20191204152236.GA22464@bogus> (raw)
In-Reply-To: <20191120142038.30746-4-ktouil@baylibre.com>
On Wed, Nov 20, 2019 at 03:20:37PM +0100, Khouloud Touil wrote:
> NVMEM framework is an interface for the at24 EEPROMs as well as for
> other drivers, instead of passing the wp-gpios over the different
> drivers each time, it would be better to pass it over the NVMEM
> subsystem once and for all.
>
> Removing the optional property form the device tree binding document.
>
> Signed-off-by: Khouloud Touil <ktouil@baylibre.com>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index e8778560d966..9894237ac432 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -145,11 +145,6 @@ properties:
> over reads to the next slave address. Please consult the manual of
> your device.
>
> - wp-gpios:
> - description:
> - GPIO to which the write-protect pin of the chip is connected.
> - maxItems: 1
> -
At least 'wp-gpios: true' is still needed or you need to reference the
common definition in nvmem.yaml. The reason being is every possible
property (and child node) needs to be listed so we can have errors on
any that aren't.
Rob
next prev parent reply other threads:[~2019-12-04 15:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:20 [PATCH 0/4] at24: move write-protect pin handling to nvmem core Khouloud Touil
2019-11-20 14:20 ` [PATCH 1/4] dt-bindings: nvmem: new optional property write-protect-gpios Khouloud Touil
2019-11-22 12:41 ` Linus Walleij
2019-11-22 12:47 ` Bartosz Golaszewski
2019-11-22 12:53 ` Linus Walleij
2019-11-22 13:04 ` Bartosz Golaszewski
2019-11-22 13:46 ` Linus Walleij
[not found] ` <CALL1Z1xpcGyh_f3ooRT+gGApoAnS7YBMd2hUKqnt+pTcAFoeAg@mail.gmail.com>
2019-11-28 13:44 ` Linus Walleij
2019-11-29 8:47 ` Bartosz Golaszewski
2019-12-04 15:14 ` Rob Herring
2019-11-22 13:10 ` Peter Rosin
2019-11-20 14:20 ` [PATCH 2/4] nvmem: add support for the write-protect pin Khouloud Touil
2019-11-22 12:47 ` Linus Walleij
2019-11-20 14:20 ` [PATCH 3/4] dt-bindings: at24: remove the optional property write-protect-gpios Khouloud Touil
2019-12-04 15:22 ` Rob Herring [this message]
2019-11-20 14:20 ` [PATCH 4/4] eeprom: at24: remove the write-protect pin support Khouloud Touil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204152236.GA22464@bogus \
--to=robh@kernel.org \
--cc=baylibre-upstreaming@groups.io \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ktouil@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).