From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DA8C2BC73 for ; Wed, 4 Dec 2019 15:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C866B2073B for ; Wed, 4 Dec 2019 15:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575473209; bh=8kwXDBusRhMdiTcg11crHBjqoGGgZN9JITQIaXs8ZFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mOLJh5YyoJozXZJH46ET9ftY2TMcj9WfXniZxR+4u/4fgxDpoTR4hrLYHIj4kGFbl +EsBfH7mTIQYxBf6xV/ustNVmvPJYXYEhrEUrgdgiYcgOyT6FriO6VcPMGOhIYmGKW TLDm5pMci/Wuu6TqO2+eUxsf3nP9FLoiB956LPpY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbfLDP0s (ORCPT ); Wed, 4 Dec 2019 10:26:48 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50941 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728256AbfLDP0s (ORCPT ); Wed, 4 Dec 2019 10:26:48 -0500 Received: by mail-wm1-f67.google.com with SMTP id p9so148332wmg.0 for ; Wed, 04 Dec 2019 07:26:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6KFJXpSjk2QbKXOKeYkEGlVAuJTKJ9X2wspCF7AiQVk=; b=mmAnbxyQH6baPNYv9PiiI3U8qXWHn93I5cVl1zbfALGpbtQfOX7cleTuK8gx0heA0Z FUa8exb28cBco7kxaBWvffEPN9i30U0alsTgagMJsrnOzvZ+G8pStrDEi+CeWeEYPnvU dCYAXx2tVjUN/qtvk3W3JoFYZVvltDBU8RGa6vrp4sZgFPBUWbk7iq9fYegnGURZhXFL mL8+NN2AAcGy5o2IeYSlq3tM03EyyW++Io/WvxAcsIiaTSeFUIRQxgceqLixxHKvQPkt UimLPXpuMtmR9dQc7tFHxik5dhtV8M6y6Dmric9+CuXLU/Du+N3d1eJioRKrF19lR+9J nAJQ== X-Gm-Message-State: APjAAAXHpeA10h7UnEqvL+gYsCekowYu6H+hMMCqH2d5tL/As8n1TVwt b4fLR8r1OjbRd1WrCOUCFLRGE1+v X-Google-Smtp-Source: APXvYqxkvyNs0giQOgDDIyCpxleWqDCEQnJO3Cr+vGWYu5oEaWn1ij1PW1TJG8ulikMieYCHh+fAPg== X-Received: by 2002:a7b:cd83:: with SMTP id y3mr36232wmj.168.1575473206330; Wed, 04 Dec 2019 07:26:46 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id n188sm8207781wme.14.2019.12.04.07.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 07:26:45 -0800 (PST) Date: Wed, 4 Dec 2019 16:26:44 +0100 From: Michal Hocko To: Thomas =?iso-8859-1?Q?Hellstr=F6m_=28VMware=29?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, Thomas Hellstrom , Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Ralph Campbell , =?iso-8859-1?B?Suly9G1l?= Glisse , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v2 2/2] drm/ttm: Fix vm page protection handling Message-ID: <20191204152644.GL25242@dhcp22.suse.cz> References: <20191203104853.4378-1-thomas_os@shipmail.org> <20191203104853.4378-3-thomas_os@shipmail.org> <20191204135219.GH25242@dhcp22.suse.cz> <20191204143521.GJ25242@dhcp22.suse.cz> <5c2658b6-b5ec-5747-c360-fada54d759ed@shipmail.org> <20191204144248.GK25242@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04-12-19 16:19:27, Thomas Hellström (VMware) wrote: > On 12/4/19 3:42 PM, Michal Hocko wrote: > > On Wed 04-12-19 15:36:58, Thomas Hellström (VMware) wrote: > > > On 12/4/19 3:35 PM, Michal Hocko wrote: > > > > On Wed 04-12-19 15:16:09, Thomas Hellström (VMware) wrote: > > > > > On 12/4/19 2:52 PM, Michal Hocko wrote: > > > > > > On Tue 03-12-19 11:48:53, Thomas Hellström (VMware) wrote: > > > > > > > From: Thomas Hellstrom > > > > > > > > > > > > > > TTM graphics buffer objects may, transparently to user-space, move > > > > > > > between IO and system memory. When that happens, all PTEs pointing to the > > > > > > > old location are zapped before the move and then faulted in again if > > > > > > > needed. When that happens, the page protection caching mode- and > > > > > > > encryption bits may change and be different from those of > > > > > > > struct vm_area_struct::vm_page_prot. > > > > > > > > > > > > > > We were using an ugly hack to set the page protection correctly. > > > > > > > Fix that and instead use vmf_insert_mixed_prot() and / or > > > > > > > vmf_insert_pfn_prot(). > > > > > > > Also get the default page protection from > > > > > > > struct vm_area_struct::vm_page_prot rather than using vm_get_page_prot(). > > > > > > > This way we catch modifications done by the vm system for drivers that > > > > > > > want write-notification. > > > > > > So essentially this should have any new side effect on functionality it > > > > > > is just making a hacky/ugly code less so? > > > > > Functionality is unchanged. The use of a on-stack vma copy was severely > > > > > frowned upon in an earlier thread, which also points to another similar > > > > > example using vmf_insert_pfn_prot(). > > > > > > > > > > https://lore.kernel.org/lkml/20190905103541.4161-2-thomas_os@shipmail.org/ > > > > > > > > > > > In other words what are the > > > > > > consequences of having page protection inconsistent from vma's? > > > > > During the years, it looks like the caching- and encryption flags of > > > > > vma::vm_page_prot have been largely removed from usage. From what I can > > > > > tell, there are no more places left that can affect TTM. We discussed > > > > > __split_huge_pmd_locked() towards the end of that thread, but that doesn't > > > > > affect TTM even with huge page-table entries. > > > > Please state all those details/assumptions you are operating on in the > > > > changelog. > > > Thanks. I'll update the patchset and add that. > > And thinking about that this also begs for a comment in the code to > > explain that some (which?) mappings might have a mismatch and the > > generic code have to be careful. Because as things stand now this seems > > to be really subtle and happen to work _now_ and might break in the future. > > Or what does prevent a generic code to stumble over this discrepancy? > > Yes we had that discussion in the thread I pointed to. I initially suggested > and argued for updating the vma::vm_page_prot using a WRITE_ONCE() (we only > have the mmap_sem in read mode), there seems to be other places in generic > code that does the same. > > But I was convinced by Andy that this was the right way and also was used > elsewhere. > > (See also https://elixir.bootlin.com/linux/latest/source/arch/x86/entry/vdso/vma.c#L116) > > I guess to have this properly formulated, what's required is that generic > code doesn't build page-table entries using vma::vm_page_prot for VM_PFNMAP > and VM_MIXEDMAP outside of driver control. Let me repeat that this belongs to a code somewhere everybody can see it rather than a "random" discussion at mailing list. Thanks! -- Michal Hocko SUSE Labs