From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1EF4C43603 for ; Wed, 4 Dec 2019 17:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA2852084F for ; Wed, 4 Dec 2019 17:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482371; bh=uVmrMTReuiw8qke0Vz4udyQimZmWzBpfxFe56+DKeUo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ELP55HfPCRNwZq0I9s+fgPM00I/po1ZLAW5cPoQY1rihze4/ZeNW0LSnwTtoMBFL4 gWUJHhey96xzsi3U4n0JlY1kN9UopgFOnwNLX7byvQbr578iYE/hfgG5lBztLGsPx+ +66Kbb5wYruZYnFXicCoPUnb9R9zH/VMw2AUnWEU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729114AbfLDR7a (ORCPT ); Wed, 4 Dec 2019 12:59:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:35824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729088AbfLDR7X (ORCPT ); Wed, 4 Dec 2019 12:59:23 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACD8620833; Wed, 4 Dec 2019 17:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482363; bh=uVmrMTReuiw8qke0Vz4udyQimZmWzBpfxFe56+DKeUo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MvApvX3CVnyoBloVTHrHJ4KUTzUTJxCECCehqbJyxv21QJlbWW5Jo0P7Lq/Hk7FyZ q81K1o6PEmNIVRMXWF3WWaBc1yNHh2S4Kuy0bUyoxmfBG3S4T67BbADdoRlgCJlTsz JkbKogNr2ThT0ZM6GMUB+thcJGYXsYx9COvPS1ww= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 58/92] tipc: fix a missing check of genlmsg_put Date: Wed, 4 Dec 2019 18:49:58 +0100 Message-Id: <20191204174333.893817920@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit 46273cf7e009231d2b6bc10a926e82b8928a9fb2 ] genlmsg_put could fail. The fix inserts a check of its return value, and if it fails, returns -EMSGSIZE. Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/tipc/netlink_compat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index d2bf92e711505..4f6fbd2f29add 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -926,6 +926,8 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock) hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_PUBL_GET); + if (!hdr) + return -EMSGSIZE; nest = nla_nest_start(args, TIPC_NLA_SOCK); if (!nest) { -- 2.20.1