* [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
@ 2019-12-04 17:45 Grygorii Strashko
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Grygorii Strashko @ 2019-12-04 17:45 UTC (permalink / raw)
To: Randy Dunlap, netdev, David S . Miller, Tony Lindgren
Cc: Sekhar Nori, linux-kernel, linux-omap, Grygorii Strashko
This series fixes Kconfig warning with CONFIG_COMPILE_TEST=y reported by
Randy Dunlap <rdunlap@infradead.org> [1]
[1] https://lkml.org/lkml/2019/12/3/1373
Grygorii Strashko (2):
net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies
detected for NET_SWITCHDEV
arm: omap2plus_defconfig: enable NET_SWITCHDEV
arch/arm/configs/omap2plus_defconfig | 3 ++-
drivers/net/ethernet/ti/Kconfig | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
2019-12-04 17:45 [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV Grygorii Strashko
@ 2019-12-04 17:45 ` Grygorii Strashko
2019-12-04 21:26 ` Randy Dunlap
2019-12-04 17:45 ` [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Grygorii Strashko
2019-12-05 22:39 ` [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Grygorii Strashko @ 2019-12-04 17:45 UTC (permalink / raw)
To: Randy Dunlap, netdev, David S . Miller, Tony Lindgren
Cc: Sekhar Nori, linux-kernel, linux-omap, Grygorii Strashko
Replace "select NET_SWITCHDEV" vs "depends on NET_SWITCHDEV" to fix Kconfig
warning with CONFIG_COMPILE_TEST=y
WARNING: unmet direct dependencies detected for NET_SWITCHDEV
Depends on [n]: NET [=y] && INET [=n]
Selected by [y]:
- TI_CPSW_SWITCHDEV [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && (ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST [=y])
because TI_CPSW_SWITCHDEV blindly selects NET_SWITCHDEV even though
INET is not set/enabled, while NET_SWITCHDEV depends on INET.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/net/ethernet/ti/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 9170572346b5..a46f4189fde3 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -62,7 +62,7 @@ config TI_CPSW
config TI_CPSW_SWITCHDEV
tristate "TI CPSW Switch Support with switchdev"
depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
- select NET_SWITCHDEV
+ depends on NET_SWITCHDEV
select TI_DAVINCI_MDIO
select MFD_SYSCON
select REGMAP
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV
2019-12-04 17:45 [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV Grygorii Strashko
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
@ 2019-12-04 17:45 ` Grygorii Strashko
2019-12-06 11:07 ` Grygorii Strashko
2019-12-05 22:39 ` [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Grygorii Strashko @ 2019-12-04 17:45 UTC (permalink / raw)
To: Randy Dunlap, netdev, David S . Miller, Tony Lindgren
Cc: Sekhar Nori, linux-kernel, linux-omap, Grygorii Strashko
The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
arch/arm/configs/omap2plus_defconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 89cce8d4bc6b..7bbef86a4e76 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
CONFIG_IP_PNP_RARP=y
CONFIG_NETFILTER=y
CONFIG_PHONET=m
+CONFIG_NET_SWITCHDEV=y
CONFIG_CAN=m
CONFIG_CAN_C_CAN=m
CONFIG_CAN_C_CAN_PLATFORM=m
@@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
# CONFIG_NET_VENDOR_STMICRO is not set
CONFIG_TI_DAVINCI_EMAC=y
CONFIG_TI_CPSW=y
+CONFIG_TI_CPSW_SWITCHDEV=y
CONFIG_TI_CPTS=y
# CONFIG_NET_VENDOR_VIA is not set
# CONFIG_NET_VENDOR_WIZNET is not set
@@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_SCHEDSTATS=y
# CONFIG_DEBUG_BUGVERBOSE is not set
-CONFIG_TI_CPSW_SWITCHDEV=y
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
@ 2019-12-04 21:26 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2019-12-04 21:26 UTC (permalink / raw)
To: Grygorii Strashko, netdev, David S . Miller, Tony Lindgren
Cc: Sekhar Nori, linux-kernel, linux-omap
On 12/4/19 9:45 AM, Grygorii Strashko wrote:
> Replace "select NET_SWITCHDEV" vs "depends on NET_SWITCHDEV" to fix Kconfig
> warning with CONFIG_COMPILE_TEST=y
>
> WARNING: unmet direct dependencies detected for NET_SWITCHDEV
> Depends on [n]: NET [=y] && INET [=n]
> Selected by [y]:
> - TI_CPSW_SWITCHDEV [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_TI [=y] && (ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST [=y])
>
> because TI_CPSW_SWITCHDEV blindly selects NET_SWITCHDEV even though
> INET is not set/enabled, while NET_SWITCHDEV depends on INET.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/net/ethernet/ti/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index 9170572346b5..a46f4189fde3 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -62,7 +62,7 @@ config TI_CPSW
> config TI_CPSW_SWITCHDEV
> tristate "TI CPSW Switch Support with switchdev"
> depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
> - select NET_SWITCHDEV
> + depends on NET_SWITCHDEV
> select TI_DAVINCI_MDIO
> select MFD_SYSCON
> select REGMAP
>
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
2019-12-04 17:45 [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV Grygorii Strashko
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
2019-12-04 17:45 ` [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Grygorii Strashko
@ 2019-12-05 22:39 ` David Miller
2019-12-06 11:04 ` Grygorii Strashko
2 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2019-12-05 22:39 UTC (permalink / raw)
To: grygorii.strashko
Cc: rdunlap, netdev, tony, nsekhar, linux-kernel, linux-omap
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Wed, 4 Dec 2019 19:45:31 +0200
> This series fixes Kconfig warning with CONFIG_COMPILE_TEST=y reported by
> Randy Dunlap <rdunlap@infradead.org> [1]
>
> [1] https://lkml.org/lkml/2019/12/3/1373
I applied patch #1 to the networking tree, the defconfig update has to be routed via
the appropriate architecture tree.
Thank you.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
2019-12-05 22:39 ` [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV David Miller
@ 2019-12-06 11:04 ` Grygorii Strashko
0 siblings, 0 replies; 8+ messages in thread
From: Grygorii Strashko @ 2019-12-06 11:04 UTC (permalink / raw)
To: David Miller; +Cc: rdunlap, netdev, tony, nsekhar, linux-kernel, linux-omap
On 06/12/2019 00:39, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Wed, 4 Dec 2019 19:45:31 +0200
>
>> This series fixes Kconfig warning with CONFIG_COMPILE_TEST=y reported by
>> Randy Dunlap <rdunlap@infradead.org> [1]
>>
>> [1] https://lkml.org/lkml/2019/12/3/1373
>
> I applied patch #1 to the networking tree, the defconfig update has to be routed via
> the appropriate architecture tree.
Thank you.
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV
2019-12-04 17:45 ` [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Grygorii Strashko
@ 2019-12-06 11:07 ` Grygorii Strashko
2019-12-06 15:50 ` Tony Lindgren
0 siblings, 1 reply; 8+ messages in thread
From: Grygorii Strashko @ 2019-12-06 11:07 UTC (permalink / raw)
To: Tony Lindgren
Cc: Randy Dunlap, netdev, David S . Miller, Sekhar Nori,
linux-kernel, linux-omap
Hi Tony,
On 04/12/2019 19:45, Grygorii Strashko wrote:
> The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
>
> Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> arch/arm/configs/omap2plus_defconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 89cce8d4bc6b..7bbef86a4e76 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
> CONFIG_IP_PNP_RARP=y
> CONFIG_NETFILTER=y
> CONFIG_PHONET=m
> +CONFIG_NET_SWITCHDEV=y
> CONFIG_CAN=m
> CONFIG_CAN_C_CAN=m
> CONFIG_CAN_C_CAN_PLATFORM=m
> @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
> # CONFIG_NET_VENDOR_STMICRO is not set
> CONFIG_TI_DAVINCI_EMAC=y
> CONFIG_TI_CPSW=y
> +CONFIG_TI_CPSW_SWITCHDEV=y
> CONFIG_TI_CPTS=y
> # CONFIG_NET_VENDOR_VIA is not set
> # CONFIG_NET_VENDOR_WIZNET is not set
> @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
> CONFIG_MAGIC_SYSRQ=y
> CONFIG_SCHEDSTATS=y
> # CONFIG_DEBUG_BUGVERBOSE is not set
> -CONFIG_TI_CPSW_SWITCHDEV=y
>
Could it be applied as fix, as without it cpsw switch driver will not be built,
so no networking on am571x-idk
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV
2019-12-06 11:07 ` Grygorii Strashko
@ 2019-12-06 15:50 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2019-12-06 15:50 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Randy Dunlap, netdev, David S . Miller, Sekhar Nori,
linux-kernel, linux-omap
* Grygorii Strashko <grygorii.strashko@ti.com> [191206 11:08]:
> Hi Tony,
>
> On 04/12/2019 19:45, Grygorii Strashko wrote:
> > The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> > NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> > to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
> >
> > Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> > arch/arm/configs/omap2plus_defconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 89cce8d4bc6b..7bbef86a4e76 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
> > CONFIG_IP_PNP_RARP=y
> > CONFIG_NETFILTER=y
> > CONFIG_PHONET=m
> > +CONFIG_NET_SWITCHDEV=y
> > CONFIG_CAN=m
> > CONFIG_CAN_C_CAN=m
> > CONFIG_CAN_C_CAN_PLATFORM=m
> > @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
> > # CONFIG_NET_VENDOR_STMICRO is not set
> > CONFIG_TI_DAVINCI_EMAC=y
> > CONFIG_TI_CPSW=y
> > +CONFIG_TI_CPSW_SWITCHDEV=y
> > CONFIG_TI_CPTS=y
> > # CONFIG_NET_VENDOR_VIA is not set
> > # CONFIG_NET_VENDOR_WIZNET is not set
> > @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
> > CONFIG_MAGIC_SYSRQ=y
> > CONFIG_SCHEDSTATS=y
> > # CONFIG_DEBUG_BUGVERBOSE is not set
> > -CONFIG_TI_CPSW_SWITCHDEV=y
> >
>
> Could it be applied as fix, as without it cpsw switch driver will not be built,
> so no networking on am571x-idk
OK I'll be applying it into fixes.
Thanks,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-06 15:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 17:45 [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV Grygorii Strashko
2019-12-04 17:45 ` [PATCH 1/2] " Grygorii Strashko
2019-12-04 21:26 ` Randy Dunlap
2019-12-04 17:45 ` [PATCH 2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV Grygorii Strashko
2019-12-06 11:07 ` Grygorii Strashko
2019-12-06 15:50 ` Tony Lindgren
2019-12-05 22:39 ` [PATCH 0/2] net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV David Miller
2019-12-06 11:04 ` Grygorii Strashko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).