From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D540C43603 for ; Wed, 4 Dec 2019 18:03:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEA1F2081B for ; Wed, 4 Dec 2019 18:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482612; bh=jQHII3kekIjKGDfMOcLc7BNncRQEMcbsFHnnxjyp1vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1bspnVzMfc5EA85X4h691MtwWzcUHxzo3mkY8EuyaKnj05ga4uZDfCDyEF8WJjTFD xJj0BAMuCNjPd11hZ3E/cKHILNCa5WzxJBi4WRc0MMuGKjociJas2atttad0G1tgKB pJ7fYmsv90lnGk8bbp0XNEo9M+6R5eklQj47dVlY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730063AbfLDSDa (ORCPT ); Wed, 4 Dec 2019 13:03:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:47256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729513AbfLDSD1 (ORCPT ); Wed, 4 Dec 2019 13:03:27 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9BCE72081B; Wed, 4 Dec 2019 18:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482606; bh=jQHII3kekIjKGDfMOcLc7BNncRQEMcbsFHnnxjyp1vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VOX6zUOorq9pq5S1GrcfTHkRnWoojnkbmxkV9JCZKd1FX+7mPU/lyEMsdqEFhZuil Z0iZ3UXa9+Dq3GDBeyOZdnSLE/53bmX1br8gnI035GAMCgVZ3MNbOIsN6sK2Rf7g2t zbXjXHkcbz+auW0K1CZwsLjUhK2Yyxkbhi/8/3v0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ross Lagerwall , Boris Ostrovsky , Sasha Levin Subject: [PATCH 4.14 064/209] xen/pciback: Check dev_data before using it Date: Wed, 4 Dec 2019 18:54:36 +0100 Message-Id: <20191204175325.706205649@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ross Lagerwall [ Upstream commit 1669907e3d1abfa3f7586e2d55dbbc117b5adba2 ] If pcistub_init_device fails, the release function will be called with dev_data set to NULL. Check it before using it to avoid a NULL pointer dereference. Signed-off-by: Ross Lagerwall Reviewed-by: Boris Ostrovsky Signed-off-by: Boris Ostrovsky Signed-off-by: Sasha Levin --- drivers/xen/xen-pciback/pci_stub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 9e480fdebe1f0..8c250f4a3a97a 100644 --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -106,7 +106,8 @@ static void pcistub_device_release(struct kref *kref) * is called from "unbind" which takes a device_lock mutex. */ __pci_reset_function_locked(dev); - if (pci_load_and_free_saved_state(dev, &dev_data->pci_saved_state)) + if (dev_data && + pci_load_and_free_saved_state(dev, &dev_data->pci_saved_state)) dev_info(&dev->dev, "Could not reload PCI state\n"); else pci_restore_state(dev); -- 2.20.1