From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E82C43603 for ; Wed, 4 Dec 2019 18:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27744205ED for ; Wed, 4 Dec 2019 18:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483608; bh=XNoYKvz5jYsa7e1+etOwz3MmWT1KcokIq3KV72exAlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IMTZYXxXJOSycEwDCTuoMClbWES5Dcg+8m3ZaBNlCeu1DsYcLe3H8i1TiOwo1VMSQ niKNoMGhSVbjxRsAhH+RBZQlvPNBplfrZSwnJb3tdfGGZ5fCqTWLdaDRDz3ZRS08MK utIa6TqSrPIVUfkTL0eeq0P4tlmwduQ1HXjeWaAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731643AbfLDSUH (ORCPT ); Wed, 4 Dec 2019 13:20:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:33612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730941AbfLDSIx (ORCPT ); Wed, 4 Dec 2019 13:08:53 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E18120674; Wed, 4 Dec 2019 18:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482933; bh=XNoYKvz5jYsa7e1+etOwz3MmWT1KcokIq3KV72exAlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QublcnU4b/6ZCijHaO6HmT0E7VGmf8z95LHCO2fCG5XxflXfMtnH/wn1E/SSqqHD3 oy7QCjzXtgpTrH7F7dgiqyM8PmLgrkZGUp7lE02KiyLhFIPZAsyLgu32pM89bI4R4A twIBEsswX7siAyrUkugqYP5/s28Zvta46Re4b92w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bert Kenward , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 139/209] sfc: initialise found bitmap in efx_ef10_mtd_probe Date: Wed, 4 Dec 2019 18:55:51 +0100 Message-Id: <20191204175332.872633447@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bert Kenward [ Upstream commit c65285428b6e7797f1bb063f33b0ae7e93397b7b ] The bitmap of found partitions in efx_ef10_mtd_probe was not initialised, causing partitions to be suppressed based off whatever value was in the bitmap at the start. Fixes: 3366463513f5 ("sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe") Signed-off-by: Bert Kenward Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/sfc/ef10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index cc3be94d05622..2d92a9fe4606c 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc/ef10.c @@ -5918,7 +5918,7 @@ static int efx_ef10_mtd_probe_partition(struct efx_nic *efx, static int efx_ef10_mtd_probe(struct efx_nic *efx) { MCDI_DECLARE_BUF(outbuf, MC_CMD_NVRAM_PARTITIONS_OUT_LENMAX); - DECLARE_BITMAP(found, EF10_NVRAM_PARTITION_COUNT); + DECLARE_BITMAP(found, EF10_NVRAM_PARTITION_COUNT) = { 0 }; struct efx_mcdi_mtd_partition *parts; size_t outlen, n_parts_total, i, n_parts; unsigned int type; -- 2.20.1