From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7936C43603 for ; Wed, 4 Dec 2019 18:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4DA720833 for ; Wed, 4 Dec 2019 18:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482914; bh=1DUZ4/SRYVLn8adnb6JLa3/MVMs1tGobVah7ENH7hKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kbOAtjiC7xVAbhw+F14vnIHuR+89RI92DoAMd5hCZwa/C/KIrPOsDeULfOipELCOl jCS4CdvjgKWSn7WJy+ayR5QuGeInCzPVl6a9Ez0v17EvHNcEFZXAMsP8Rs6hsZFKE4 L8qyGE4gn5NFuEpwJ54XklS8XYPDI7Jj8+kJkMm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730440AbfLDSId (ORCPT ); Wed, 4 Dec 2019 13:08:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:60164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730896AbfLDSIY (ORCPT ); Wed, 4 Dec 2019 13:08:24 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDDE420674; Wed, 4 Dec 2019 18:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482903; bh=1DUZ4/SRYVLn8adnb6JLa3/MVMs1tGobVah7ENH7hKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gst50i9lK84zberQLDazzUeCc0Ao6BDfefw6d0bCfRKyr1aNc2e3TxiG5g07HfGj5 tSNezsQDMnEA/d7AXFAHPg7TDSmV+uUhYT72O55BBD2yFIW951yKTX928c5diw1/PW XqFf/EBKLck+8TyoAsteB5Wt6u/wP+crGxVM6rCc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eugen Hristev , Guenter Roeck , Wim Van Sebroeck , Lee Jones Subject: [PATCH 4.14 179/209] watchdog: sama5d4: fix WDD value to be always set to max Date: Wed, 4 Dec 2019 18:56:31 +0100 Message-Id: <20191204175335.812989624@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eugen Hristev commit 8632944841d41a36d77dd1fa88d4201b5291100f upstream. WDD value must be always set to max (0xFFF) otherwise the hardware block will reset the board on the first ping of the watchdog. Signed-off-by: Eugen Hristev Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/watchdog/sama5d4_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -111,9 +111,7 @@ static int sama5d4_wdt_set_timeout(struc u32 value = WDT_SEC2TICKS(timeout); wdt->mr &= ~AT91_WDT_WDV; - wdt->mr &= ~AT91_WDT_WDD; wdt->mr |= AT91_WDT_SET_WDV(value); - wdt->mr |= AT91_WDT_SET_WDD(value); /* * WDDIS has to be 0 when updating WDD/WDV. The datasheet states: When @@ -255,7 +253,7 @@ static int sama5d4_wdt_probe(struct plat timeout = WDT_SEC2TICKS(wdd->timeout); - wdt->mr |= AT91_WDT_SET_WDD(timeout); + wdt->mr |= AT91_WDT_SET_WDD(WDT_SEC2TICKS(MAX_WDT_TIMEOUT)); wdt->mr |= AT91_WDT_SET_WDV(timeout); ret = sama5d4_wdt_init(wdt);