Re: [PATCH v4 3/6] KVM: X86: Use APIC_DEST_* macros properly in kvm_lapic_irq.dest_mode

[Peter Xu <peterx@redhat.com>]

On Tue, Dec 03, 2019 at 02:20:36PM -0800, Sean Christopherson wrote:
> On Tue, Dec 03, 2019 at 05:15:19PM -0500, Peter Xu wrote:
> > On Tue, Dec 03, 2019 at 02:07:52PM -0800, Sean Christopherson wrote:
> > > On Tue, Dec 03, 2019 at 11:59:00AM -0500, Peter Xu wrote:
> > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > > > index b79cd6aa4075..f815c97b1b57 100644
> > > > --- a/arch/x86/include/asm/kvm_host.h
> > > > +++ b/arch/x86/include/asm/kvm_host.h
> > > > @@ -1022,6 +1022,11 @@ struct kvm_lapic_irq {
> > > >  	bool msi_redir_hint;
> > > >  };
> > > >  
> > > > +static inline u16 kvm_lapic_irq_dest_mode(bool dest_mode)
> > > > +{
> > > > +	return dest_mode ? APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL;
> > > 
> > > IMO this belongs in ioapic.c as it's specifically provided for converting
> > > an I/O APIC redirection entry into a local APIC destination mode.  Without
> > > the I/O APIC context, %true==APIC_DEST_LOGICAL looks like a completely
> > > arbitrary decision.  And if it's in ioapic.c, it can take the union
> > > of a bool, which avoids the casting and shortens the callers.  E.g.:
> > > 
> > > static u64 ioapic_to_lapic_dest_mode(union kvm_ioapic_redirect_entry *e)
> > > {
> > > 	return e->fields.dest_mode ?  APIC_DEST_LOGICAL : APIC_DEST_PHYSICAL;
> > > }
> > > 
> > > The other option would be to use the same approach as delivery_mode and
> > > open code the shift.
> > 
> > It's also used for MSI address encodings, please see below [1].
> 
> Boooh.  How about naming the param "logical_dest_mode" or something else
> with "logical" in the name so that the correctness of the function itself
> is apparent?

Ok, will do.  Thanks,

-- 
Peter Xu