archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <>
To: Taejoon Song <>,
	Andrew Morton <>
Subject: Re: [PATCH] zram: try to avoid worst-case scenario on same element pages
Date: Wed, 4 Dec 2019 14:54:51 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Dec 04, 2019 at 10:53:38AM +0900, Taejoon Song wrote:
> The worst-case scenario on finding same element pages is that almost
> all elements are same at the first glance but only last few elements
> are different.
> Since the same element tends to be grouped from the beginning of the
> pages, if we check the first element with the last element before
> looping through all elements, we might have some chances to quickly
> detect non-same element pages.
> 1. Test is done under LG webOS TV (64-bit arch)
> 2. Dump the swap-out pages (~819200 pages)
> 3. Analyze the pages with simple test script which counts the iteration
>    number and measures the speed at off-line
> Under 64-bit arch, the worst iteration count is PAGE_SIZE / 8 bytes = 512.
> The speed is based on the time to consume page_same_filled() function only.
> The result, on average, is listed as below:
>                                    Num of Iter    Speed(MB/s)
> Looping-Forward (Orig)                 38            99265
> Looping-Backward                       36           102725
> Last-element-check (This Patch)        33           125072
> The result shows that the average iteration count decreases by 13% and
> the speed increases by 25% with this patch. This patch does not increase
> the overall time complexity, though.
> I also ran simpler version which uses backward loop. Just looping backward
> also makes some improvement, but less than this patch.
> Signed-off-by: Taejoon Song <>
Acked-by: Minchan Kim <>

I think it's very reasonable optimization with small cost.

  reply	other threads:[~2019-12-04 22:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  1:53 Taejoon Song
2019-12-04 22:54 ` Minchan Kim [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-10  7:40 Taejoon Song
2020-01-10 16:45 ` Minchan Kim
2019-12-03 10:43 Taejoon Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] zram: try to avoid worst-case scenario on same element pages' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).