From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DE1C43603 for ; Thu, 5 Dec 2019 02:15:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 015E0214B2 for ; Thu, 5 Dec 2019 02:15:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728944AbfLECPx (ORCPT ); Wed, 4 Dec 2019 21:15:53 -0500 Received: from mga02.intel.com ([134.134.136.20]:44502 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728121AbfLECPs (ORCPT ); Wed, 4 Dec 2019 21:15:48 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2019 18:15:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,279,1571727600"; d="scan'208";a="263147669" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2019 18:15:46 -0800 From: Wei Yang To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: richard.weiyang@gmail.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.or, tglx@linutronix.de, Wei Yang Subject: [Patch v2 3/6] x86/mm: Make page_size_mask unsigned int clearly Date: Thu, 5 Dec 2019 10:14:00 +0800 Message-Id: <20191205021403.25606-4-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191205021403.25606-1-richardw.yang@linux.intel.com> References: <20191205021403.25606-1-richardw.yang@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org page_size_mask is defined as unsigned, so it would be more proper to use 1U to assign and compare this value. Signed-off-by: Wei Yang --- arch/x86/mm/init.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 4fa5fd641865..0eb5edb63fa2 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -165,12 +165,12 @@ int after_bootmem __ro_after_init; early_param_on_off("gbpages", "nogbpages", direct_gbpages, CONFIG_X86_DIRECT_GBPAGES); struct map_range { - unsigned long start; - unsigned long end; - unsigned page_size_mask; + unsigned long start; + unsigned long end; + unsigned int page_size_mask; }; -static int page_size_mask; +static unsigned int page_size_mask __ro_after_init; static void __init probe_page_size_mask(void) { @@ -180,7 +180,7 @@ static void __init probe_page_size_mask(void) * large pages into small in interrupt context, etc. */ if (boot_cpu_has(X86_FEATURE_PSE) && !debug_pagealloc_enabled()) - page_size_mask |= 1 << PG_LEVEL_2M; + page_size_mask |= 1U << PG_LEVEL_2M; else direct_gbpages = 0; @@ -204,7 +204,7 @@ static void __init probe_page_size_mask(void) /* Enable 1 GB linear kernel mappings if available: */ if (direct_gbpages && boot_cpu_has(X86_FEATURE_GBPAGES)) { printk(KERN_INFO "Using GB pages for direct mapping\n"); - page_size_mask |= 1 << PG_LEVEL_1G; + page_size_mask |= 1U << PG_LEVEL_1G; } else { direct_gbpages = 0; } @@ -284,8 +284,8 @@ static void __ref adjust_range_page_size_mask(struct map_range *mr, int i; for (i = 0; i < nr_range; i++) { - if ((page_size_mask & (1<page_size_mask & (1<page_size_mask & (1U<page_size_mask & (1<page_size_mask & (1U<page_size_mask & (1<page_size_mask & (1U<