From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fix the SPDX syntax and bash interprester pointer
Date: Thu, 5 Dec 2019 10:44:54 +0530 [thread overview]
Message-ID: <20191205051454.GB1795@Slackware> (raw)
In-Reply-To: <56303cd3-fcf8-49cd-f66a-4db7e382774c@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On 19:36 Wed 04 Dec 2019, Randy Dunlap wrote:
>On 12/3/19 1:53 AM, Bhaskar Chowdhury wrote:
>> SPDX syntax was complining by checkpatch fixed it,added space before it.
>> And add bash interpreter to find by the env .
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> scripts/kernel_modules_info.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh
>> index f005c47a3aa6..3a9b00988ed3 100755
>> --- a/scripts/kernel_modules_info.sh
>> +++ b/scripts/kernel_modules_info.sh
>> @@ -1,5 +1,5 @@
>> -#!/bin/bash -
>> -#SPDX-License-Identifier: GPL-2.0
>> +#!/usr/bin/env bash
>> +# SPDX-License-Identifier: GPL-2.0
>> #===============================================================================
>> #
>> # FILE: kernel_modules_info.sh
>>
>
>a. There is no good reason for patch 2/2. Just merge the 2 patches.
>
>b. The big header comment in patch 1/2 is not needed and is unwanted.
>Just put some or all of that in the patch description/comment message.
>
Sure, will do.
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-05 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 9:53 [PATCH 2/2] fix the SPDX syntax and bash interprester pointer Bhaskar Chowdhury
2019-12-05 3:36 ` Randy Dunlap
2019-12-05 5:14 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205051454.GB1795@Slackware \
--to=unixbhaskar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rdunlap@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).