From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: David Airlie <airlied@linux.ie>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
YT Shen <yt.shen@mediatek.com>,
Thierry Reding <thierry.reding@gmail.com>,
CK Hu <ck.hu@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>, <tfiga@chromium.org>,
<drinkcat@chromium.org>, <linux-kernel@vger.kernel.org>,
<srv_heupstream@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>
Subject: [PATCH v4 4/7] drm/mediatek: disable all the planes in atomic_disable
Date: Thu, 5 Dec 2019 17:27:46 +0800 [thread overview]
Message-ID: <20191205092749.4021-5-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20191205092749.4021-1-bibby.hsieh@mediatek.com>
Under shadow register case, we do not disable all the plane before
disable all the hardwares. Fix it.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index e887a6877bcd..e40c8cf7d74f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -550,6 +550,7 @@ static void mtk_drm_crtc_atomic_disable(struct drm_crtc *crtc,
}
mtk_crtc->pending_planes = true;
+ mtk_drm_crtc_hw_config(mtk_crtc);
/* Wait for planes to be disabled */
drm_crtc_wait_one_vblank(crtc);
--
2.18.0
next prev parent reply other threads:[~2019-12-05 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 9:27 [PATCH v4 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM Bibby Hsieh
2019-12-05 9:27 ` [PATCH v4 1/7] drm/mediatek: use DRM core's atomic commit helper Bibby Hsieh
2019-12-05 9:27 ` [PATCH v4 2/7] drm/mediatek: handle events when enabling/disabling crtc Bibby Hsieh
2019-12-05 9:27 ` [PATCH v4 3/7] drm/mediatek: update cursors by using async atomic update Bibby Hsieh
2019-12-06 1:53 ` CK Hu
2019-12-05 9:27 ` Bibby Hsieh [this message]
2019-12-06 1:57 ` [PATCH v4 4/7] drm/mediatek: disable all the planes in atomic_disable CK Hu
2019-12-05 9:27 ` [PATCH v4 5/7] drm/mediatek: remove unused external function Bibby Hsieh
2019-12-05 9:27 ` [PATCH v4 6/7] drm/mediatek: support CMDQ interface in ddp component Bibby Hsieh
2019-12-06 2:05 ` CK Hu
2019-12-05 9:27 ` [PATCH v4 7/7] drm/mediatek: apply CMDQ control flow Bibby Hsieh
2019-12-06 2:55 ` CK Hu
2019-12-09 4:48 ` [PATCH v4 0/7] drm/mediatek: fix cursor issue and apply CMDQ in MTK DRM CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205092749.4021-5-bibby.hsieh@mediatek.com \
--to=bibby.hsieh@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).