From: Kamil Konieczny <k.konieczny@samsung.com>
To: k.konieczny@samsung.com
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: [PATCH v3 0/3] devfreq: improve devfreq statistics counting
Date: Thu, 5 Dec 2019 15:55:24 +0100 [thread overview]
Message-ID: <20191205145527.26117-1-k.konieczny@samsung.com> (raw)
In-Reply-To: CGME20191205145542eucas1p2b39536c9c186d5656f39d214baa32670@eucas1p2.samsung.com
Hi,
this patch series tries to improve devfreq statistics:
- do conversion to use 64-bit jiffies for storing elapsed time and prevent
counters overflow,
- add ability to reset statistics using sysfs,
- move statistics data to separate structure for improved code
readability and maintenance.
Changes in v3:
- changed types of cur_time and last_stats_updated to u64 as this is
returned by get_jiffies_64() in 1/3
- add checks for zero in input and clear stats only when zero is written
to trans_stats
- change documentation of trans_stat in sysfs
- removed freq_table and max_state from struct devfreq_stats as they are
already present in struct devfreq_dev_profile
- renamed last_stat_updated to last_update, as 'stat' is already present
in struct devfreq_stats
- define struct devfreq_stats stats; in devfreq as there is only one
stats per devfreq
- improve descriptions of devfreq_stats and stats
- use profile instead of devfreq->profile in devfreq_add_device, as this
var is already parameter
- added Reviewed-by: Matthias Kaehlcke <mka@chromium.org> to 3/3
Changes in v2:
- added Acked-by to first patch
- dropped spinlock patch, there is mutex used for protecting stats data
- rewrite clearing statistics, suggested by Chanwoo Choi: reuse
trans_stats sysfs file, any write to it will clear devfreq stats
- dropped change var name last_stat_updated
- squashed three last patches into one, as it turned out that freq_table
from devfreq_profile is used by other drivers
- rebased on linux-next
Kamil Konieczny (3):
devfreq: change time stats to 64-bit
devfreq: add clearing transitions stats
devfreq: move statistics to separate struct
Documentation/ABI/testing/sysfs-class-devfreq | 11 ++-
drivers/devfreq/devfreq.c | 92 ++++++++++++-------
include/linux/devfreq.h | 26 ++++--
3 files changed, 83 insertions(+), 46 deletions(-)
--
2.24.0
next parent reply other threads:[~2019-12-05 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191205145542eucas1p2b39536c9c186d5656f39d214baa32670@eucas1p2.samsung.com>
2019-12-05 14:55 ` Kamil Konieczny [this message]
[not found] ` <CGME20191205145543eucas1p11798d11e91f6a691d5989db7cba81b96@eucas1p1.samsung.com>
2019-12-05 14:55 ` [PATCH v3 1/3] devfreq: change time stats to 64-bit Kamil Konieczny
2019-12-06 1:37 ` Chanwoo Choi
[not found] ` <CGME20191205145543eucas1p1a317647203c47be07bbcee7867fb3e1e@eucas1p1.samsung.com>
2019-12-05 14:55 ` [PATCH v3 2/3] devfreq: add clearing transitions stats Kamil Konieczny
2019-12-06 2:01 ` Chanwoo Choi
[not found] ` <CGME20191205145544eucas1p17e64389fdee24549a523c624c13194d7@eucas1p1.samsung.com>
2019-12-05 14:55 ` [PATCH v3 3/3] devfreq: move statistics to separate struct Kamil Konieczny
2019-12-06 5:30 ` Chanwoo Choi
[not found] ` <CGME20191206052729epcas1p110d11c728db1ebd7487c8c5fe936df21@epcas1p1.samsung.com>
2019-12-06 5:33 ` [PATCH v4] PM / devfreq: Move statistics to separate struct devfreq_stats Chanwoo Choi
2019-12-06 5:36 ` Chanwoo Choi
[not found] ` <CGME20191206021208epcas1p1d7b3bb434108f38b0ef83b1c7d7a5d79@epcas1p1.samsung.com>
2019-12-06 2:18 ` [PATCH v4] PM / devfreq: add clearing transitions stats Chanwoo Choi
2019-12-06 2:19 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205145527.26117-1-k.konieczny@samsung.com \
--to=k.konieczny@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).