From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDFDC43603 for ; Thu, 5 Dec 2019 18:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07E482464F for ; Thu, 5 Dec 2019 18:45:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P5pXOeJK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730182AbfLESpH (ORCPT ); Thu, 5 Dec 2019 13:45:07 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37215 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729780AbfLESpG (ORCPT ); Thu, 5 Dec 2019 13:45:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575571505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9iewXkgZ98kUOBpFLU0jCIRcpaJJCeUS5vqH0PGqdK8=; b=P5pXOeJKLQOvwLibqVdR9UvaocyRcePE3C6FgLZvr2QPpF70mHY8nnfIdkIvRLTY8KtoAu +O7b+Pb+65DKop/tNlxvPXqjhiCXTRkwPiymT6QXB8alaOi2OCKMkelPprWL7hjElBu9ML X6ELaKgLT3jP8iV8ZqVcE9ixU03EpKg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-LnBD3G7mO46kQrGlG551XQ-1; Thu, 05 Dec 2019 13:45:01 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3669C1883545; Thu, 5 Dec 2019 18:44:59 +0000 (UTC) Received: from shalem.localdomain.com (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D6AB6013D; Thu, 5 Dec 2019 18:44:51 +0000 (UTC) From: Hans de Goede To: Ard Biesheuvel , Darren Hart , Andy Shevchenko , Luis Chamberlain , Greg Kroah-Hartman , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Jonathan Corbet , Dmitry Torokhov Cc: Hans de Goede , Peter Jones , Dave Olsthoorn , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v9 05/10] test_firmware: add support for firmware_request_platform Date: Thu, 5 Dec 2019 19:44:17 +0100 Message-Id: <20191205184422.7316-6-hdegoede@redhat.com> In-Reply-To: <20191205184422.7316-1-hdegoede@redhat.com> References: <20191205184422.7316-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: LnBD3G7mO46kQrGlG551XQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for testing firmware_request_platform through a new trigger_request_platform trigger. Signed-off-by: Hans de Goede --- lib/test_firmware.c | 68 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/lib/test_firmware.c b/lib/test_firmware.c index 251213c872b5..9af00cfc8979 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -24,6 +24,7 @@ #include #include #include +#include =20 #define TEST_FIRMWARE_NAME=09"test-firmware.bin" #define TEST_FIRMWARE_NUM_REQS=094 @@ -507,12 +508,76 @@ static ssize_t trigger_request_store(struct device *d= ev, } static DEVICE_ATTR_WO(trigger_request); =20 +#ifdef CONFIG_EFI_EMBEDDED_FIRMWARE +static ssize_t trigger_request_platform_store(struct device *dev, +=09=09=09=09=09 struct device_attribute *attr, +=09=09=09=09=09 const char *buf, size_t count) +{ +=09static const u8 test_data[] =3D { +=09=090x55, 0xaa, 0x55, 0xaa, 0x01, 0x02, 0x03, 0x04, +=09=090x55, 0xaa, 0x55, 0xaa, 0x05, 0x06, 0x07, 0x08, +=09=090x55, 0xaa, 0x55, 0xaa, 0x10, 0x20, 0x30, 0x40, +=09=090x55, 0xaa, 0x55, 0xaa, 0x50, 0x60, 0x70, 0x80 +=09}; +=09struct efi_embedded_fw fw; +=09int rc; +=09char *name; + +=09name =3D kstrndup(buf, count, GFP_KERNEL); +=09if (!name) +=09=09return -ENOSPC; + +=09pr_info("inserting test platform fw '%s'\n", name); +=09fw.name =3D name; +=09fw.data =3D (void *)test_data; +=09fw.length =3D sizeof(test_data); +=09list_add(&fw.list, &efi_embedded_fw_list); + +=09pr_info("loading '%s'\n", name); + +=09mutex_lock(&test_fw_mutex); +=09release_firmware(test_firmware); +=09test_firmware =3D NULL; +=09rc =3D firmware_request_platform(&test_firmware, name, dev); +=09if (rc) { +=09=09pr_info("load of '%s' failed: %d\n", name, rc); +=09=09goto out; +=09} +=09if (test_firmware->size !=3D sizeof(test_data) || +=09 memcmp(test_firmware->data, test_data, sizeof(test_data)) !=3D 0) { +=09=09pr_info("firmware contents mismatch for '%s'\n", name); +=09=09rc =3D -EINVAL; +=09=09goto out; +=09} +=09pr_info("loaded: %zu\n", test_firmware->size); +=09rc =3D count; + +out: +=09mutex_unlock(&test_fw_mutex); + +=09list_del(&fw.list); +=09kfree(name); + +=09return rc; +} +static DEVICE_ATTR_WO(trigger_request_platform); +#endif + static DECLARE_COMPLETION(async_fw_done); =20 static void trigger_async_request_cb(const struct firmware *fw, void *cont= ext) { =09test_firmware =3D fw; =09complete(&async_fw_done); + + + + + + + + + } =20 static ssize_t trigger_async_request_store(struct device *dev, @@ -903,6 +968,9 @@ static struct attribute *test_dev_attrs[] =3D { =09TEST_FW_DEV_ATTR(trigger_request), =09TEST_FW_DEV_ATTR(trigger_async_request), =09TEST_FW_DEV_ATTR(trigger_custom_fallback), +#ifdef CONFIG_EFI_EMBEDDED_FIRMWARE +=09TEST_FW_DEV_ATTR(trigger_request_platform), +#endif =20 =09/* These use the config and can use the test_result */ =09TEST_FW_DEV_ATTR(trigger_batched_requests), --=20 2.23.0