From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40B9C2D0B1 for ; Fri, 6 Dec 2019 11:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 858362464E for ; Fri, 6 Dec 2019 11:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbfLFLdw (ORCPT ); Fri, 6 Dec 2019 06:33:52 -0500 Received: from comms.puri.sm ([159.203.221.185]:46516 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfLFLdw (ORCPT ); Fri, 6 Dec 2019 06:33:52 -0500 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 360A0DFE25; Fri, 6 Dec 2019 03:33:51 -0800 (PST) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8GWJpsWM_QVg; Fri, 6 Dec 2019 03:33:50 -0800 (PST) From: Martin Kepplinger To: daniel.lezcano@linaro.org, edubezval@gmail.com, rui.zhang@intel.com Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, amit.kucheria@linaro.org, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: Re: [PATCH V4 4/4] thermal/drivers/cpu_cooling: Rename to cpufreq_cooling Date: Fri, 6 Dec 2019 12:33:15 +0100 Message-Id: <20191206113315.18954-1-martin.kepplinger@puri.sm> In-Reply-To: <20191204153930.9128-4-daniel.lezcano@linaro.org> References: <20191204153930.9128-4-daniel.lezcano@linaro.org> Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I tested this on the librem5-devkit and see the cooling devices in sysfs. I configure ARM_PSCI_CPUIDLE, not ARM_CPUIDLE and add the patch below in register the cooling device there. "psci_idle" is listed as the cpuidle_driver. That's what I'm running, in case you want to see it all: https://source.puri.sm/martin.kepplinger/linux-next/commits/next-20191205/librem5_cpuidle_mainline_atf so I add a trip temperature description like this: https://source.puri.sm/martin.kepplinger/linux-next/commit/361f49f93ae2c477fd012790831cabd0ed976660 When I let the SoC heat up, cpuidle cooling won't kick it. In sysfs: catting the relevant files in /sys/class/thermal after heating up, if that makes sense: 87000 85000 85000 thermal-cpufreq-0 1 thermal-idle-0 0 thermal-idle-1 0 thermal-idle-2 0 thermal-idle-3 0 with ARM_CPUIDLE instead of ARM_PSCI_CPUIDLE (and registering the cooling dev during cpuidle-arm.c init) I won't have a cpuidle driver and thus no cpu-sleep state at all. Can you see where the problem here lies? thanks! martin --- drivers/cpuidle/cpuidle-psci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c index f3c1a2396f98..de6e7f444a66 100644 --- a/drivers/cpuidle/cpuidle-psci.c +++ b/drivers/cpuidle/cpuidle-psci.c @@ -8,6 +8,7 @@ #define pr_fmt(fmt) "CPUidle PSCI: " fmt +#include #include #include #include @@ -195,6 +196,8 @@ static int __init psci_idle_init_cpu(int cpu) if (ret) goto out_kfree_drv; + cpuidle_cooling_register(drv); + return 0; out_kfree_drv: -- 2.20.1