From: David Sterba <dsterba@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, ebiggers@kernel.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] pipe: Fixes [ver #2]
Date: Fri, 6 Dec 2019 14:56:04 +0100 [thread overview]
Message-ID: <20191206135604.GB2734@twin.jikos.cz> (raw)
In-Reply-To: <157558502272.10278.8718685637610645781.stgit@warthog.procyon.org.uk>
On Thu, Dec 05, 2019 at 10:30:22PM +0000, David Howells wrote:
> David Howells (2):
> pipe: Remove assertion from pipe_poll()
> pipe: Fix missing mask update after pipe_wait()
For reference, I've retested current master (b0d4beaa5a4b7d), that
incldes the 2 pipe fixes, the test still hangs.
The stack now points to pipe_wait but otherwise seems to be the same:
[<0>] pipe_wait+0x72/0xc0
[<0>] pipe_write+0x217/0x4b0
[<0>] new_sync_write+0x11e/0x1c0
[<0>] vfs_write+0xc1/0x1d0
[<0>] kernel_write+0x2c/0x40
[<0>] send_cmd+0x78/0xf0 [btrfs]
[<0>] send_extent_data+0x4af/0x52a [btrfs]
[<0>] process_extent+0xe5d/0xeb4 [btrfs]
[<0>] changed_cb+0xcf5/0xd2f [btrfs]
[<0>] send_subvol+0x8af/0xc0d [btrfs]
[<0>] btrfs_ioctl_send+0xe2b/0xef0 [btrfs]
[<0>] _btrfs_ioctl_send+0x80/0x110 [btrfs]
[<0>] btrfs_ioctl+0x14b8/0x3120 [btrfs]
[<0>] do_vfs_ioctl+0xa1/0x750
[<0>] ksys_ioctl+0x70/0x80
[<0>] __x64_sys_ioctl+0x16/0x20
[<0>] do_syscall_64+0x56/0x240
[<0>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
(gdb) l *(pipe_wait+0x72)
0x622 is in pipe_wait (fs/pipe.c:120).
115 * is considered a noninteractive wait:
116 */
117 prepare_to_wait(&pipe->wait, &wait, TASK_INTERRUPTIBLE);
118 pipe_unlock(pipe);
119 schedule();
120 finish_wait(&pipe->wait, &wait);
121 pipe_lock(pipe);
122 }
123
124 static void anon_pipe_buf_release(struct pipe_inode_info *pipe,
next prev parent reply other threads:[~2019-12-06 13:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 22:30 [PATCH 0/2] pipe: Fixes [ver #2] David Howells
2019-12-05 22:30 ` [PATCH 1/2] pipe: Remove assertion from pipe_poll() " David Howells
2019-12-05 22:30 ` [PATCH 2/2] pipe: Fix missing mask update after pipe_wait() " David Howells
2019-12-05 23:58 ` Linus Torvalds
2019-12-06 13:56 ` David Sterba [this message]
2019-12-06 17:09 ` [PATCH 0/2] pipe: Fixes " Linus Torvalds
2019-12-06 17:42 ` Linus Torvalds
2019-12-06 18:59 ` Linus Torvalds
2019-12-07 21:31 ` Akemi Yagi
2019-12-08 16:45 ` Akemi Yagi
2019-12-08 18:04 ` Linus Torvalds
2019-12-09 3:07 ` Linus Torvalds
2019-12-06 20:28 ` Linus Torvalds
2019-12-06 21:04 ` Linus Torvalds
2019-12-07 3:50 ` Linus Torvalds
2019-12-07 4:01 ` Linus Torvalds
2019-12-07 22:47 ` Linus Torvalds
2019-12-09 9:53 ` Vincent Guittot
2019-12-09 17:48 ` Linus Torvalds
2019-12-09 17:57 ` Akemi Yagi
2019-12-09 18:18 ` Linus Torvalds
2019-12-09 18:24 ` Linus Torvalds
2019-12-18 20:59 ` Josh Triplett
2019-12-10 2:58 ` DJ Delorie
2019-12-10 14:38 ` Vincent Guittot
2019-12-10 17:39 ` Linus Torvalds
2019-12-11 18:09 ` DJ Delorie
2019-12-11 18:59 ` Linus Torvalds
2019-12-12 10:18 ` Konstantin Khlebnikov
2019-12-18 22:51 ` Linus Torvalds
2019-12-19 0:03 ` Josh Triplett
2019-12-19 0:14 ` Josh Triplett
2019-12-19 0:51 ` Linus Torvalds
2019-12-19 0:54 ` Linus Torvalds
2019-12-19 7:56 ` David Howells
2019-12-19 16:35 ` Linus Torvalds
2019-12-11 20:55 ` David Howells
2019-12-12 1:28 ` Linus Torvalds
2019-12-12 7:34 ` David Howells
2019-12-09 14:55 ` David Sterba
2019-12-06 21:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206135604.GB2734@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).