From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B510C43603 for ; Fri, 6 Dec 2019 18:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40DA524686 for ; Fri, 6 Dec 2019 18:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ExSOppud" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbfLFSxH (ORCPT ); Fri, 6 Dec 2019 13:53:07 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40736 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbfLFSxH (ORCPT ); Fri, 6 Dec 2019 13:53:07 -0500 Received: by mail-pg1-f195.google.com with SMTP id k25so3731584pgt.7 for ; Fri, 06 Dec 2019 10:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K3ULS82TM5X3oy+N7bLM5wCXYGvU66vvX1ioV7TywQA=; b=ExSOppud6x7oyh7jQafYUvPvNOXeUGL6Tfs3axjJWXXEm7+DGmcpWm8uUuwQWjiKsw 4DjGbjcvL1SBYWbmQpIom/13VK14MV/ANsxs/0s4iCCkZ76s1Sl18Vhfhtn8LX/WPqJ+ n+fTieTyvg5PXprzNJYdOguIF8yOjsAf0CpvuVnXL7DPDYJDdxZ8a/exvEKNp86KhrhZ IIa6KnJ9KuGTdQ/XUGYiALS0YPjRRMxY8uRhKCjTf8aVs+sP4Kvk4gqza6tXGgtLX9tq esQx6v+KQw0qrhBwJb66uhgu1RgYTqWUK1wlICYCm3tCe3rBwm1OGllhwXUh9AcrGXA3 7eyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K3ULS82TM5X3oy+N7bLM5wCXYGvU66vvX1ioV7TywQA=; b=aEZvftYU1FI1bo9XOIdOdB92hVYxY/c35TAKxSJYfY3IssMcEDVrCBY2w6nI4HfJsi L/Sn5nAUrTuTU5suEIkl3qUTYRzM2ythu2crmQKjTParR3fOsDVIjUsN43zU8GJtDPBQ qGdg414t3mJnJFlxv+S7SRzsDEYy4kXAWCI0elCv34cnK2cro4+V5O+DBtZyFBPkbz9M 7wEz3QSuYP1Y6QYL21jo2PD1GeCCTOBLfMfJ0acmEpgWMwg51N8RaChq+vj4dmMVVTq/ ut35x/8w7WOInRiYVWqMvFr9lIySkCPBUfnY35mkyHwrFCRhjoViVilAic4jBmyaoXzf jsvw== X-Gm-Message-State: APjAAAXt+3CACLNc7M3B955QdYe97SnrPQ34KWK9vUs2kYcTyo279Wzp kzU0A6cJ39VpKCWNAR3GocRdpU7tWBY= X-Google-Smtp-Source: APXvYqxmgKQUom0IC5pFsT4lzSuFsQPzwlPTXfnMVHpgbstIu3U8KPunAzMuP13hE8dxBSRjmv7kqw== X-Received: by 2002:a63:c12:: with SMTP id b18mr5041685pgl.156.1575658386217; Fri, 06 Dec 2019 10:53:06 -0800 (PST) Received: from google.com ([2620:15c:100:202:d78:d09d:ec00:5fa7]) by smtp.gmail.com with ESMTPSA id h14sm10333962pfn.174.2019.12.06.10.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 10:53:05 -0800 (PST) Date: Fri, 6 Dec 2019 10:53:01 -0800 From: Oliver Upton To: Krish Sadhukhan Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: nVMX: expose "load IA32_PERF_GLOBAL_CTRL" controls Message-ID: <20191206185301.GA93531@google.com> References: <1574346557-18344-1-git-send-email-pbonzini@redhat.com> <7fea1f06-9abb-cdd1-9cb9-8655fe207e96@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7fea1f06-9abb-cdd1-9cb9-8655fe207e96@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, Sorry I didn't see this earlier. Thank you for addressing this! On Thu, Nov 21, 2019 at 10:42:18AM -0800, Krish Sadhukhan wrote: > > On 11/21/19 6:29 AM, Paolo Bonzini wrote: > > These controls were added by the recent commit 03a8871add95 ("KVM: > > nVMX: Expose load IA32_PERF_GLOBAL_CTRL VM-{Entry,Exit} control", > > 2019-11-13), so we should advertise them to userspace from > > KVM_GET_MSR_FEATURE_INDEX_LIST, as well. > > > > Cc: Oliver Upton > > Signed-off-by: Paolo Bonzini > > --- > > arch/x86/kvm/vmx/nested.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > > index 4aea7d304beb..4b4ce6a804ff 100644 > > --- a/arch/x86/kvm/vmx/nested.c > > +++ b/arch/x86/kvm/vmx/nested.c > > @@ -5982,6 +5982,7 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps, > > #ifdef CONFIG_X86_64 > > VM_EXIT_HOST_ADDR_SPACE_SIZE | > > #endif > > + VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | > > VM_EXIT_LOAD_IA32_PAT | VM_EXIT_SAVE_IA32_PAT; > > msrs->exit_ctls_high |= > > VM_EXIT_ALWAYSON_WITHOUT_TRUE_MSR | > > @@ -6001,6 +6002,7 @@ void nested_vmx_setup_ctls_msrs(struct nested_vmx_msrs *msrs, u32 ept_caps, > > #ifdef CONFIG_X86_64 > > VM_ENTRY_IA32E_MODE | > > #endif > > + VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL | > > VM_ENTRY_LOAD_IA32_PAT; > > msrs->entry_ctls_high |= > > (VM_ENTRY_ALWAYSON_WITHOUT_TRUE_MSR | VM_ENTRY_LOAD_IA32_EFER); > Reviewed-by: Krish Sadhukhan Reviewed-by: Oliver Upton