From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D68C0C43603 for ; Mon, 9 Dec 2019 22:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B22FF20637 for ; Mon, 9 Dec 2019 22:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727030AbfLIW2s (ORCPT ); Mon, 9 Dec 2019 17:28:48 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36492 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbfLIW2r (ORCPT ); Mon, 9 Dec 2019 17:28:47 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D934615492867; Mon, 9 Dec 2019 14:28:46 -0800 (PST) Date: Mon, 09 Dec 2019 14:28:46 -0800 (PST) Message-Id: <20191209.142846.388476377747170130.davem@davemloft.net> To: colin.king@canonical.com Cc: aelior@marvell.com, GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2][RESEND] qed: remove redundant assignments to rc From: David Miller In-Reply-To: <20191209131607.71580-1-colin.king@canonical.com> References: <20191209131607.71580-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 09 Dec 2019 14:28:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Mon, 9 Dec 2019 13:16:07 +0000 > From: Colin Ian King > > The variable rc is assigned with a value that is never read and > it is re-assigned a new value later on. The assignment is redundant > and can be removed. Clean up multiple occurrances of this pattern. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks Colin.