From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=3.0 tests=DKIM_ADSP_NXDOMAIN, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCF8C2D0C0 for ; Mon, 9 Dec 2019 02:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8FF020709 for ; Mon, 9 Dec 2019 02:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbfLICJh (ORCPT ); Sun, 8 Dec 2019 21:09:37 -0500 Received: from li1843-175.members.linode.com ([172.104.24.175]:57366 "EHLO mail.stoffel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbfLICJh (ORCPT ); Sun, 8 Dec 2019 21:09:37 -0500 X-Greylist: delayed 533 seconds by postgrey-1.27 at vger.kernel.org; Sun, 08 Dec 2019 21:09:36 EST Received: from quad.stoffel.org (66-189-75-104.dhcp.oxfr.ma.charter.com [66.189.75.104]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.stoffel.org (Postfix) with ESMTPSA id 80E521EDDC; Sun, 8 Dec 2019 21:00:42 -0500 (EST) Received: by quad.stoffel.org (Postfix, from userid 1000) id E9A93A5DE1; Sun, 8 Dec 2019 21:00:41 -0500 (EST) Date: Sun, 8 Dec 2019 21:00:41 -0500 From: John Stoffel To: Matthew Wilcox Cc: Al Viro , Tiezhu Yang , "Theodore Y. Ts'o" , Jaegeuk Kim , Chao Yu , Eric Biggers , Tyler Hicks , linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] fs: introduce is_dot_dotdot helper for cleanup Message-ID: <20191209020041.et776tzhxqsqqfs5@quad.stoffel.home> References: <1575718548-19017-1-git-send-email-yangtiezhu@loongson.cn> <20191208034144.GP4203@ZenIV.linux.org.uk> <20191208123804.GB32169@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191208123804.GB32169@bombadil.infradead.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 08, 2019 at 04:38:04AM -0800, Matthew Wilcox wrote: > On Sun, Dec 08, 2019 at 03:41:44AM +0000, Al Viro wrote: > > On Sat, Dec 07, 2019 at 07:35:48PM +0800, Tiezhu Yang wrote: > > > There exists many similar and duplicate codes to check "." and "..", > > > so introduce is_dot_dotdot helper to make the code more clean. > > > > Umm... No objections, in principle, but... you try to say that name > > (e.g. in a phone conversation) without stuttering ;-/ > > > > Any suggestions from native speakers? > > I used "is_dot_or_dotdot" when discussing this patch with my wife verbally. *thumbs up* Both for the wife, and the name. :-) --