From: "Artur Świgoń" <a.swigon@samsung.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org
Cc: "Artur Świgoń" <a.swigon@samsung.com>,
cw00.choi@samsung.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org,
b.zolnierkie@samsung.com, m.szyprowski@samsung.com,
inki.dae@samsung.com, sw0312.kim@samsung.com,
k.konieczny@samsung.com, leonard.crestez@nxp.com
Subject: [PATCH v3 3/4] devfreq: exynos-bus: Change goto-based logic to if-else logic
Date: Mon, 9 Dec 2019 11:49:01 +0100 [thread overview]
Message-ID: <20191209104902.11904-4-a.swigon@samsung.com> (raw)
In-Reply-To: <20191209104902.11904-1-a.swigon@samsung.com>
This patch improves code readability by changing the following construct:
> if (cond)
> goto passive;
> foo();
> goto out;
> passive:
> bar();
> out:
into this:
> if (cond)
> bar();
> else
> foo();
Signed-off-by: Artur Świgoń <a.swigon@samsung.com>
---
drivers/devfreq/exynos-bus.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index 19d9f9f8ced2..0b557df63666 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -427,19 +427,13 @@ static int exynos_bus_probe(struct platform_device *pdev)
goto err_reg;
if (passive)
- goto passive;
+ ret = exynos_bus_profile_init_passive(bus, profile);
+ else
+ ret = exynos_bus_profile_init(bus, profile);
- ret = exynos_bus_profile_init(bus, profile);
if (ret < 0)
goto err;
- goto out;
-passive:
- ret = exynos_bus_profile_init_passive(bus, profile);
- if (ret < 0)
- goto err;
-
-out:
max_state = bus->devfreq->profile->max_state;
min_freq = (bus->devfreq->profile->freq_table[0] / 1000);
max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000);
--
2.17.1
next prev parent reply other threads:[~2019-12-09 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191209105030eucas1p11e28297118da5a1d9f3a8c955584a4bf@eucas1p1.samsung.com>
2019-12-09 10:48 ` [PATCH v3 0/4] devfreq: Clean up exynos-bus driver Artur Świgoń
[not found] ` <CGME20191209105031eucas1p137c3c5b0046570453e1ebed2dcd88277@eucas1p1.samsung.com>
2019-12-09 10:48 ` [PATCH v3 1/4] devfreq: exynos-bus: Extract exynos_bus_profile_init() Artur Świgoń
2019-12-10 4:20 ` Chanwoo Choi
[not found] ` <CGME20191209105032eucas1p13fa6c46a1e80cdda68ab4bac3e008b8f@eucas1p1.samsung.com>
2019-12-09 10:49 ` [PATCH v3 2/4] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive() Artur Świgoń
2019-12-10 4:20 ` Chanwoo Choi
[not found] ` <CGME20191209105033eucas1p21ee8064e1d6917b403c06ee59a97421d@eucas1p2.samsung.com>
2019-12-09 10:49 ` Artur Świgoń [this message]
[not found] ` <CGME20191209105034eucas1p277be9a40363fec76b4241d28e71e40d2@eucas1p2.samsung.com>
2019-12-09 10:49 ` [PATCH v3 4/4] devfreq: exynos-bus: Clean up code Artur Świgoń
2019-12-10 4:20 ` Chanwoo Choi
2019-12-11 14:39 ` Artur Świgoń
2019-12-12 1:52 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209104902.11904-4-a.swigon@samsung.com \
--to=a.swigon@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=k.konieczny@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).