From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8438FC2BD09 for ; Mon, 9 Dec 2019 14:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58D7B207FD for ; Mon, 9 Dec 2019 14:53:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fv4lpIeR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfLIOxg (ORCPT ); Mon, 9 Dec 2019 09:53:36 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:36664 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfLIOxf (ORCPT ); Mon, 9 Dec 2019 09:53:35 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D07A5DAD; Mon, 9 Dec 2019 15:53:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575903213; bh=Q0OVJhjw7SZuhsekU9fG/W4V8dGuID7ElTtvVg2tjfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fv4lpIeREWadJYjO759G72RPdXeU5ytjXx/ob10hZoTe/IswAGeDQLCHxUI4DX4Tt tPlgWX51TCYGLR+dbgXIc4ZEPe+ngZdGMNcP0i/g8iawWiI0m71Fv7ci5WtugvivTl 8Tu1OQw3xhB28KH+8FSBX9B1XQUjhWiBXUruY6rc= Date: Mon, 9 Dec 2019 16:53:26 +0200 From: Laurent Pinchart To: Hsin-Yi Wang Cc: dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Nicolas Boichat , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Archit Taneja , p.zabel@pengutronix.de, Enric Balletbo i Serra , Matthias Brugger , Russell King Subject: Re: [PATCH RESEND 1/4] dt-bindings: drm/bridge: analogix-anx7688: Add ANX7688 transmitter binding Message-ID: <20191209145326.GC12841@pendragon.ideasonboard.com> References: <20191209145016.227784-1-hsinyi@chromium.org> <20191209145016.227784-2-hsinyi@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191209145016.227784-2-hsinyi@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hsin-Yi, Thank you for the patch. On Mon, Dec 09, 2019 at 10:50:13PM +0800, Hsin-Yi Wang wrote: > From: Nicolas Boichat > > Add support for analogix,anx7688 > > Signed-off-by: Nicolas Boichat > Signed-off-by: Hsin-Yi Wang > --- > .../bindings/display/bridge/anx7688.txt | 32 +++++++++++++++++++ How about converting this to yaml bindings already ? It's fairly simple and gives you DT validation. > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.txt b/Documentation/devicetree/bindings/display/bridge/anx7688.txt > new file mode 100644 > index 000000000000..78b55bdb18f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.txt > @@ -0,0 +1,32 @@ > +Analogix ANX7688 SlimPort (Single-Chip Transmitter for DP over USB-C) > +--------------------------------------------------------------------- > + > +The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per > +second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video > +resolution from a smartphone or tablet with full function USB-C. > + > +This binding only describes the HDMI to DP display bridge. > + > +Required properties: > + > + - compatible : "analogix,anx7688" > + - reg : I2C address of the device (fixed at 0x2c) > + > +Optional properties: > + > + - Video port for HDMI input, using the DT bindings defined in [1]. > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + anx7688: anx7688@2c { > + compatible = "analogix,anx7688"; > + reg = <0x2c>; > + > + port { > + anx7688_in: endpoint { > + remote-endpoint = <&hdmi0_out>; > + }; > + }; > + }; > -- > 2.24.0.393.g34dc348eaf-goog > -- Regards, Laurent Pinchart