From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Fabio Estevam <festevam@gmail.com>,
netdev@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] ARM i.MX6q: make sure PHY fixup for KSZ9031 is applied only on one board
Date: Mon, 9 Dec 2019 18:39:52 +0100 [thread overview]
Message-ID: <20191209173952.qnkzfrbixjgi2jfy@pengutronix.de> (raw)
In-Reply-To: <20191209171508.GD9099@lunn.ch>
Hi Andrew,
On Mon, Dec 09, 2019 at 06:15:08PM +0100, Andrew Lunn wrote:
> Hi Oleksij
>
> > This patch changes the MICREL KSZ9031 fixup, which was introduced for
> > the "Data Modul eDM-QMX6" board in following patch, to be only activated
> > for this specific board.
>
> ...
>
> > static void __init imx6q_enet_phy_init(void)
> > {
> > + /* Warning: please do not extend this fixup list. This fixups are
> > + * applied even on boards where related PHY is not directly connected
> > + * to the ethernet controller. For example with switch in the middle.
> > + */
> > if (IS_BUILTIN(CONFIG_PHYLIB)) {
> > phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK,
> > ksz9021rn_phy_fixup);
> > - phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
> > - ksz9031rn_phy_fixup);
> > +
> > + if (of_machine_is_compatible("dmo,imx6q-edmqmx6"))
> > + phy_register_fixup_for_uid(PHY_ID_KSZ9031,
> > + MICREL_PHY_ID_MASK,
> > + ksz9031rn_phy_fixup);
> > +
> > phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
> > ar8031_phy_fixup);
> > phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,
>
> What about the other 3 fixups? Are they not also equally broken,
> applied for all boards, not specific boards?
Yes. all of them are broken.
I just trying to not wake all wasp at one time. Most probably there are
board working by accident. So, it will be good to have at least separate
patches for each fixup.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2019-12-09 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 8:44 [PATCH v1] ARM i.MX6q: make sure PHY fixup for KSZ9031 is applied only on one board Oleksij Rempel
2019-12-09 17:15 ` Andrew Lunn
2019-12-09 17:39 ` Oleksij Rempel [this message]
2019-12-09 17:51 ` Andrew Lunn
2019-12-10 7:54 ` Oleksij Rempel
2020-01-20 9:50 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209173952.qnkzfrbixjgi2jfy@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).