From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C058C43603 for ; Tue, 10 Dec 2019 02:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AB692080D for ; Tue, 10 Dec 2019 02:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n+GOtvSP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727325AbfLJC24 (ORCPT ); Mon, 9 Dec 2019 21:28:56 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:40746 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbfLJC2H (ORCPT ); Mon, 9 Dec 2019 21:28:07 -0500 Received: by mail-il1-f194.google.com with SMTP id b15so14705149ila.7; Mon, 09 Dec 2019 18:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0e87BZGmWkpLZLDiE87VOkYIktS/iX8I8E4fJx5a9NY=; b=n+GOtvSPknXgbu54HzzLx8JyCIOthua/Xt9Z5URQLbfTulFkamol44lExxgjyQTj+W sL/X0Ev8yRNGCKRX7BApxDX2NYsEMBVkGYnYdU7JweO6Cm5hOq0XmwWH9SEdpmzkPctU 1tSnf5ZSs5MPljRkFu77NnUOtPFsPabSnvgOm2PwYmo2EHV57Tx5TpYEf7Y3AO60soTo OK08ly3q5LO3vPlfwpXhbLeeMxUB1B6ofOZvE2u45XhWgp5FeMEyWgZkyJ/1SpsqDGM6 WCJcs70MQF64ECyUawb9Qlk4nFB/8jVaAHsavT9oNvVIkX3mmJLvNYB7OO6m4pkOhXzH 1a1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0e87BZGmWkpLZLDiE87VOkYIktS/iX8I8E4fJx5a9NY=; b=YpXgVaB24g4gv61ue9EtmSW3iO+xUrfH8A0mhQQH7txIe1o261NDP0fN20wxy0H+/8 S2ubj69KKlwQbi4LVrlY15aTQV/hJh2bSFgZtba1BHYo+n5KNJ40gkeEcYVA5k2tedcd RTKY9XCcLAJAlhCEvCqC3BTCnS5XDAWRUaTyJLYzr3XZKP4ATMsuZbji7ck+XEoDrEEo QS5H0AR/KIOnKf/Y0jO5xAfcxp8VDpkjqGpzhocs4P9gnpiZYBo3z6NLVvIPILN4d2VC k2ki4Y5NPytYGhtVK7RM6C3UWb1tceJXEp6hV9QSvUIQTB4I1F88mp81wdYwP67rdHTG /YyA== X-Gm-Message-State: APjAAAU1QCFFMSkOGS3lw6kXHxJ+1n9MUAyXZLkPd0/5UoQSMdXGkGqn Vbt7c10pKwRG0cDYcvoWEntbREmBRRw= X-Google-Smtp-Source: APXvYqz3AlwrdqmwgW9W4bGUn7KveBWqqgmBHtChvpH1e1rJt2J847o/QgNtSoCNV4DWKh+dCEFmjA== X-Received: by 2002:a92:8fd2:: with SMTP id r79mr8743639ilk.165.1575944886593; Mon, 09 Dec 2019 18:28:06 -0800 (PST) Received: from localhost.localdomain (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id l9sm334052ioh.77.2019.12.09.18.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 18:28:05 -0800 (PST) From: Jim Cromie To: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org Cc: gregkh@linuxfoundation.org, linux@rasmusvillemoes.dk, Jim Cromie , Arnd Bergmann , Jessica Yu , linux-arch@vger.kernel.org Subject: [PATCH v4 04/16] dyndbg: rename __verbose section to __dyndbg Date: Mon, 9 Dec 2019 19:27:30 -0700 Message-Id: <20191210022742.822686-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191210022742.822686-1-jim.cromie@gmail.com> References: <20191210022742.822686-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dyndbg populates its callsite info into __verbose section, change that to a more specific and descriptive name, __dyndbg. Also, per checkpatch: simplify __attribute(..) to __section(__dyndbg) declaration. and 1 spelling fix Signed-off-by: Jim Cromie --- include/asm-generic/vmlinux.lds.h | 6 +++--- include/linux/dynamic_debug.h | 4 ++-- kernel/module.c | 2 +- lib/dynamic_debug.c | 12 ++++++------ 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index dae64600ccbf..82694efe3a83 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -285,9 +285,9 @@ *(__tracepoints) \ /* implement dynamic printk debug */ \ . = ALIGN(8); \ - __start___verbose = .; \ - KEEP(*(__verbose)) \ - __stop___verbose = .; \ + __start___dyndbg = .; \ + KEEP(*(__dyndbg)) \ + __stop___dyndbg = .; \ LIKELY_PROFILE() \ BRANCH_PROFILE() \ TRACE_PRINTKS() \ diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 4cf02ecd67de..802480ea8708 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -80,7 +80,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, #define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \ static struct _ddebug __aligned(8) \ - __attribute__((section("__verbose"))) name = { \ + __section(__dyndbg) name = { \ .modname = KBUILD_MODNAME, \ .function = __func__, \ .filename = __FILE__, \ @@ -133,7 +133,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, /* * "Factory macro" for generating a call to func, guarded by a - * DYNAMIC_DEBUG_BRANCH. The dynamic debug decriptor will be + * DYNAMIC_DEBUG_BRANCH. The dynamic debug descriptor will be * initialized using the fmt argument. The function will be called with * the address of the descriptor as first argument, followed by all * the varargs. Note that fmt is repeated in invocations of this diff --git a/kernel/module.c b/kernel/module.c index ff2d7359a418..a9c052cc30c5 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3237,7 +3237,7 @@ static int find_module_sections(struct module *mod, struct load_info *info) if (section_addr(info, "__obsparm")) pr_warn("%s: Ignoring obsolete parameters\n", mod->name); - info->debug = section_objs(info, "__verbose", + info->debug = section_objs(info, "__dyndbg", sizeof(*info->debug), &info->num_debug); return 0; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index c86c97154657..0a4588fe342e 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -39,8 +39,8 @@ #include -extern struct _ddebug __start___verbose[]; -extern struct _ddebug __stop___verbose[]; +extern struct _ddebug __start___dyndbg[]; +extern struct _ddebug __stop___dyndbg[]; struct ddebug_table { struct list_head link; @@ -1010,14 +1010,14 @@ static int __init dynamic_debug_init(void) int n = 0, entries = 0, modct = 0; int verbose_bytes = 0; - if (__start___verbose == __stop___verbose) { + if (__start___dyndbg == __stop___dyndbg) { pr_warn("_ddebug table is empty in a CONFIG_DYNAMIC_DEBUG build\n"); return 1; } - iter = __start___verbose; + iter = __start___dyndbg; modname = iter->modname; iter_start = iter; - for (; iter < __stop___verbose; iter++) { + for (; iter < __stop___dyndbg; iter++) { entries++; verbose_bytes += strlen(iter->modname) + strlen(iter->function) + strlen(iter->filename) + strlen(iter->format); @@ -1040,7 +1040,7 @@ static int __init dynamic_debug_init(void) ddebug_init_success = 1; vpr_info("%d modules, %d entries and %d bytes in ddebug tables, %d bytes in (readonly) verbose section\n", modct, entries, (int)(modct * sizeof(struct ddebug_table)), - verbose_bytes + (int)(__stop___verbose - __start___verbose)); + verbose_bytes + (int)(__stop___dyndbg - __start___dyndbg)); /* apply ddebug_query boot param, dont unload tables on err */ if (ddebug_setup_string[0] != '\0') { -- 2.23.0