From: "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Linux v5.5 serious PCI bug
Date: Tue, 10 Dec 2019 09:28:00 +0200 [thread overview]
Message-ID: <20191210072800.GY2665@lahna.fi.intel.com> (raw)
In-Reply-To: <PSXP216MB043809A423446A6EF2C7909A80580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Mon, Dec 09, 2019 at 01:33:49PM +0000, Nicholas Johnson wrote:
> On Mon, Dec 09, 2019 at 03:12:39PM +0200, mika.westerberg@linux.intel.com wrote:
> > On Mon, Dec 09, 2019 at 12:34:04PM +0000, Nicholas Johnson wrote:
> > > Hi,
> > >
> > > I have compiled Linux v5.5-rc1 and thought all was good until I
> > > hot-removed a Gigabyte Aorus eGPU from Thunderbolt. The driver for the
> > > GPU was not loaded (blacklisted) so the crash is nothing to do with the
> > > GPU driver.
> > >
> > > We had:
> > > - kernel NULL pointer dereference
> > > - refcount_t: underflow; use-after-free.
> > >
> > > Attaching dmesg for now; will bisect and come back with results.
> >
> > Looks like something related to iommu. Does it work if you disable it?
> > (intel_iommu=off in the command line).
> On Mon, Dec 09, 2019 at 03:12:39PM +0200, mika.westerberg@linux.intel.com wrote:
> > On Mon, Dec 09, 2019 at 12:34:04PM +0000, Nicholas Johnson wrote:
> > > Hi,
> > >
> > > I have compiled Linux v5.5-rc1 and thought all was good until I
> > > hot-removed a Gigabyte Aorus eGPU from Thunderbolt. The driver for the
> > > GPU was not loaded (blacklisted) so the crash is nothing to do with the
> > > GPU driver.
> > >
> > > We had:
> > > - kernel NULL pointer dereference
> > > - refcount_t: underflow; use-after-free.
> > >
> > > Attaching dmesg for now; will bisect and come back with results.
> >
> > Looks like something related to iommu. Does it work if you disable it?
> > (intel_iommu=off in the command line).
> I thought it could be that, too.
>
> The attachment "dmesg-4" from the original email is with iommu parameters.
> The attachment "dmesg-5" from the original email is with no iommu parameters.
> Attaching here "dmesg-6" with the iommu explicitly set off like you said.
>
> No difference, still broken. Although, with iommu off, there are less stack traces.
>
> Could it be sysfs-related?
Bisect would probably be the best option to find the culprit commit.
There are couple of commits done for pciehp so reverting them one by one
may help as well:
87d0f2a5536f PCI: pciehp: Prevent deadlock on disconnect
75fcc0ce72e5 PCI: pciehp: Do not disable interrupt twice on suspend
b94ec12dfaee PCI: pciehp: Refactor infinite loop in pcie_poll_cmd()
157c1062fcd8 PCI: pciehp: Avoid returning prematurely from sysfs requests
next prev parent reply other threads:[~2019-12-10 7:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 12:34 Linux v5.5 serious PCI bug Nicholas Johnson
2019-12-09 12:37 ` Pavel Machek
2019-12-09 13:07 ` Nicholas Johnson
2019-12-09 13:12 ` mika.westerberg
2019-12-09 13:29 ` Nicholas Johnson
2019-12-09 13:33 ` Nicholas Johnson
2019-12-10 7:28 ` mika.westerberg [this message]
2019-12-10 12:00 ` Nicholas Johnson
2019-12-10 12:29 ` Lukas Wunner
2019-12-10 12:46 ` Takashi Iwai
2019-12-11 7:33 ` Jiasen Lin
2019-12-10 12:52 ` Nicholas Johnson
2019-12-10 12:34 ` mika.westerberg
2019-12-10 13:39 ` [PATCH] ALSA: hda/hdmi - Fix duplicate unref of pci_dev Lukas Wunner
2019-12-10 13:41 ` Takashi Iwai
2019-12-10 13:47 ` Nicholas Johnson
2019-12-10 13:50 ` Takashi Iwai
2019-12-10 15:34 ` Deucher, Alexander
2019-12-10 15:46 ` Lukas Wunner
2019-12-10 15:53 ` Deucher, Alexander
2019-12-10 16:10 ` Takashi Iwai
2019-12-10 16:51 ` Deucher, Alexander
2019-12-10 16:13 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210072800.GY2665@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).