From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD96C2D0BF for ; Tue, 10 Dec 2019 12:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1F53222C4 for ; Tue, 10 Dec 2019 12:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbfLJM3o (ORCPT ); Tue, 10 Dec 2019 07:29:44 -0500 Received: from bmailout3.hostsharing.net ([176.9.242.62]:56999 "EHLO bmailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727131AbfLJM3o (ORCPT ); Tue, 10 Dec 2019 07:29:44 -0500 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 125AA100B01B2; Tue, 10 Dec 2019 13:29:42 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id B9112ECCD5; Tue, 10 Dec 2019 13:29:41 +0100 (CET) Date: Tue, 10 Dec 2019 13:29:41 +0100 From: Lukas Wunner To: Nicholas Johnson Cc: "mika.westerberg@linux.intel.com" , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , alexander.deucher@amd.com, tiwai@suse.de Subject: Re: Linux v5.5 serious PCI bug Message-ID: <20191210122941.zzybs4z5jphpjsu2@wunner.de> References: <20191209131239.GP2665@lahna.fi.intel.com> <20191210072800.GY2665@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [cc += Alex, Takashi] On Tue, Dec 10, 2019 at 12:00:23PM +0000, Nicholas Johnson wrote: > On Tue, Dec 10, 2019 at 09:28:00AM +0200, mika.westerberg@linux.intel.com wrote: > > On Mon, Dec 09, 2019 at 01:33:49PM +0000, Nicholas Johnson wrote: > > > On Mon, Dec 09, 2019 at 03:12:39PM +0200, mika.westerberg@linux.intel.com wrote: > > > > On Mon, Dec 09, 2019 at 12:34:04PM +0000, Nicholas Johnson wrote: > > > > > I have compiled Linux v5.5-rc1 and thought all was good until I > > > > > hot-removed a Gigabyte Aorus eGPU from Thunderbolt. The driver for the > > > > > GPU was not loaded (blacklisted) so the crash is nothing to do with the > > > > > GPU driver. > > > > > > > > > > We had: > > > > > - kernel NULL pointer dereference > > > > > - refcount_t: underflow; use-after-free. > > The following is the culprit responsible for the issues: > > commit 586bc4aab878efcf672536f0cdec3d04b6990c94 > Author: Alex Deucher > Date: Fri Nov 22 16:43:50 2019 -0500 > > ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD Does the below fix the issue? -- >8 -- diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 35b4526f0d28..b856b89378ac 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1419,7 +1419,6 @@ static bool atpx_present(void) return true; } } - pci_dev_put(pdev); } return false; }