From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ELF: don't copy ELF header around
Date: Tue, 10 Dec 2019 17:56:11 -0800 [thread overview]
Message-ID: <20191210175611.d615f21e177d5a550a8926f0@linux-foundation.org> (raw)
In-Reply-To: <20191208171242.GA19716@avx2>
On Sun, 8 Dec 2019 20:12:42 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> ELF header is read into bprm->buf[] by generic execve code.
>
> Save a memcpy and allocate just one header for the interpreter instead
> of two headers (64 bytes instead of 128 on 64-bit).
Hard to review. Why were there two copies in the first place? Because
of the need to modify the caller's version when we do
`loc->elf_ex.e_entry += load_bias', yes? Any other place?
Local variable `loc' can go away now, yes?
next prev parent reply other threads:[~2019-12-11 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 17:12 [PATCH] ELF: don't copy ELF header around Alexey Dobriyan
2019-12-11 1:56 ` Andrew Morton [this message]
2019-12-11 7:19 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210175611.d615f21e177d5a550a8926f0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).