From: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Phillip Lougher <phillip@squashfs.org.uk>
Subject: Re: Regression in squashfs mount option handling in v5.4
Date: Tue, 10 Dec 2019 19:50:02 +0100 [thread overview]
Message-ID: <20191210185002.GA20850@gentoo-tp.home> (raw)
In-Reply-To: <6af16095-eab0-9e99-6782-374705d545e4@infradead.org>
On Sat, Nov 30, 2019 at 10:56:47AM -0800, Randy Dunlap wrote:
> [adding Cc-s]
>
> On 11/30/19 10:15 AM, Jeremi Piotrowski wrote:
> > Hi,
> >
> > I'm working on an embedded project which uses 'rauc' as an updater. rauc mounts
> > a squashfs image using
> >
> > mount -t squashfs -o ro,loop,sizelimit=xxx squashfs.img /mnt
> >
> > On my system mount is busybox, and busybox does not know the sizelimit
> > parameter, so it simply passes it on to the mount syscall. The syscall
> > arguments end up being:
> >
> > mount("/dev/loop0", "dir", "squashfs", MS_RDONLY|MS_SILENT, "sizelimit=xxx")
> >
> > Until kernel 5.4 this worked, since 5.4 this returns EINVAL and dmesg contains
> > the line "squashfs: Unknown parameter 'sizelimit'". I believe this has to do
> > with the conversion of squashfs to the new mount api.
> >
> > This is an unfortunate regression, and it does not seem like this can be simply
> > reverted. What is the suggested course of action?
> >
> > Please cc me on replies, I'm not subscribed to the list.
> >
> > Thanks,
> > Jeremi
> >
>
>
> --
> ~Randy
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
Ping. This is preventing me from updating the kernel on my systems.
next prev parent reply other threads:[~2019-12-10 18:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 18:15 Regression in squashfs mount option handling in v5.4 Jeremi Piotrowski
2019-11-30 18:56 ` Randy Dunlap
2019-12-10 18:50 ` Jeremi Piotrowski [this message]
2019-12-10 22:10 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210185002.GA20850@gentoo-tp.home \
--to=jeremi.piotrowski@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).