From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D1CC3F68F for ; Tue, 10 Dec 2019 21:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DE33205C9 for ; Tue, 10 Dec 2019 21:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576014586; bh=SgKtEPnqVxF0Va4TfbyUSL22ciLWUHPlgxeLtNInAOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GgG9Suorb0p2y8EMf6XNjleook4zZeiQlPcHSExwBPnmddJNN5cj7qRA25NkOzIEU Ddhdf1IycR95K48x/16yW/xYiUwlpssz/uCB0vWO+rbnq7+aKieJvqFeVlmPYtcJaQ exRBL1Z3CL2td7Y57TzTxEMblerNX3OwFvYi6Q9Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729951AbfLJVtg (ORCPT ); Tue, 10 Dec 2019 16:49:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:55982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727883AbfLJVId (ORCPT ); Tue, 10 Dec 2019 16:08:33 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E832B24697; Tue, 10 Dec 2019 21:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576012112; bh=SgKtEPnqVxF0Va4TfbyUSL22ciLWUHPlgxeLtNInAOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cXXOdRPHesjrbZfaNi6F4K/Qesf06jsmUIbbfaO+mgxct6hSBumKQb5tIr1iONFhT 0yLV5EgFHLPMsGT/+iKxgNL1Eaj/AFmwU8xhFQ6JzPqeZsT/brDxn7CUAjBWBdsAT0 RULAOodqTIxxOr7G3y81MuG1/hJlV8RBM1DiNcro= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Pascal van Leeuwen , Herbert Xu , Sasha Levin , linux-crypto@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 085/350] crypto: inside-secure - Fix a maybe-uninitialized warning Date: Tue, 10 Dec 2019 16:03:10 -0500 Message-Id: <20191210210735.9077-46-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210210735.9077-1-sashal@kernel.org> References: <20191210210735.9077-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 74e6bd472b6d9e80ec9972989d8991736fe46c51 ] A previous fixup avoided an unused variable warning but replaced it with a slightly scarier warning: drivers/crypto/inside-secure/safexcel.c:1100:6: error: variable 'irq' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] This is harmless as it is impossible to get into this case, but the compiler has no way of knowing that. Add an explicit error handling case to make it obvious to both compilers and humans reading the source. Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n") Signed-off-by: Arnd Bergmann Acked-by: Pascal van Leeuwen Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/inside-secure/safexcel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 294debd435b6b..991a4425f006a 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -1120,6 +1120,8 @@ static int safexcel_request_ring_irq(void *pdev, int irqid, irq_name, irq); return irq; } + } else { + return -ENXIO; } ret = devm_request_threaded_irq(dev, irq, handler, -- 2.20.1