From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CE8C43603 for ; Tue, 10 Dec 2019 22:42:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DB11207FF for ; Tue, 10 Dec 2019 22:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576017777; bh=RIKUxv5AeoPcoU46UvWDVR4Uj2fied/+jolNwWU6a74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=d3vsuD9TPANVZDRnC+Gg7YC280USNOdaYDhV6pZt0qUNJJXTtw2HvsRpNxzVDhvaj 9+sMHkSUr1cxdXng/0602jbgHxzS0S3hmohVGcs2jekLrx3XpdkOYV2VbhcNNKTbvi 1RumrcJfALEzQ+8Yqck7y9T8Zw+aCQZhJa7Ovl64= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728953AbfLJWmz (ORCPT ); Tue, 10 Dec 2019 17:42:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:51150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728152AbfLJWbN (ORCPT ); Tue, 10 Dec 2019 17:31:13 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B8D820828; Tue, 10 Dec 2019 22:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576017073; bh=RIKUxv5AeoPcoU46UvWDVR4Uj2fied/+jolNwWU6a74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bJ9Y5KdaFuJBLKSc2MzsqHxbJAb45DnIDN/bdkkIdgBFROyXTMpCJ1RPMWFr+MvOP S9C5lC0UmiWwVARlCnyxZYIuYLU+fMnlYWQAPxV0gi7PsWA1DHewPEozIjpS8qheJg GQVfVHvSN/lNnsmr/hqVSsPnuo2mBpcxhZAvgh5M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Leo Yan , Alexander Shishkin , Jiri Olsa , Mark Rutland , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH AUTOSEL 4.9 31/91] perf test: Report failure for mmap events Date: Tue, 10 Dec 2019 17:29:35 -0500 Message-Id: <20191210223035.14270-31-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210223035.14270-1-sashal@kernel.org> References: <20191210223035.14270-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan [ Upstream commit 6add129c5d9210ada25217abc130df0b7096ee02 ] When fail to mmap events in task exit case, it misses to set 'err' to -1; thus the testing will not report failure for it. This patch sets 'err' to -1 when fails to mmap events, thus Perf tool can report correct result. Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT events") Signed-off-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/20191011091942.29841-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/tests/task-exit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index b0d005d295a90..de2ddfe0f7c3c 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c @@ -98,6 +98,7 @@ int test__task_exit(int subtest __maybe_unused) if (perf_evlist__mmap(evlist, 128, true) < 0) { pr_debug("failed to mmap events: %d (%s)\n", errno, str_error_r(errno, sbuf, sizeof(sbuf))); + err = -1; goto out_delete_evlist; } -- 2.20.1