From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EAF8C43603 for ; Tue, 10 Dec 2019 22:38:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43E2D207FF for ; Tue, 10 Dec 2019 22:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576017526; bh=oOxMJ+A2UfXI1FaJjvAhzHsorqxw6QouucVm0mMiEqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Kg5Ci8wG0cgc4NiIFX0qZ5b8QD4Sc1AYBSoO1NKNHO2c2jIeqUCJ8KKa4gmhsS1+R OjYRfV7rMSLSYdj5GsnTxNn/5zbnDGJ3H1d8AC1GkXWZo9PTtk/oEhW0qSbPzgS3Mp 1HJ/cYGz74yZe4c+t9yLAVFHqIiziZ7Wk45v2+pQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730042AbfLJWip (ORCPT ); Tue, 10 Dec 2019 17:38:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:54514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729857AbfLJWdg (ORCPT ); Tue, 10 Dec 2019 17:33:36 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 637CD20838; Tue, 10 Dec 2019 22:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576017216; bh=oOxMJ+A2UfXI1FaJjvAhzHsorqxw6QouucVm0mMiEqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vv8kv61PuSQ5/Tw7o6Hz2ReheVEJCnRrGKoH+JE2L3iEXO3iB1h8m4GBRQSxu59Vv k7lWfWfBFb0w+pDtkQvi8HVe/LChbsmqkjqp8CKWINnlILKB2VdOVa/x4i1uNzzXeQ ifJRxx2ZAm42S0yqfJIsPJo/7pslOw3Jhx4xC3J4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Yingliang , Sean Young , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 16/71] media: flexcop-usb: fix NULL-ptr deref in flexcop_usb_transfer_init() Date: Tue, 10 Dec 2019 17:32:21 -0500 Message-Id: <20191210223316.14988-16-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191210223316.14988-1-sashal@kernel.org> References: <20191210223316.14988-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 649cd16c438f51d4cd777e71ca1f47f6e0c5e65d ] If usb_set_interface() failed, iface->cur_altsetting will not be assigned and it will be used in flexcop_usb_transfer_init() It may lead a NULL pointer dereference. Check usb_set_interface() return value in flexcop_usb_init() and return failed to avoid using this NULL pointer. Signed-off-by: Yang Yingliang Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/b2c2/flexcop-usb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c index 83d3a5cf272f2..932fa31e0624a 100644 --- a/drivers/media/usb/b2c2/flexcop-usb.c +++ b/drivers/media/usb/b2c2/flexcop-usb.c @@ -474,7 +474,13 @@ static int flexcop_usb_transfer_init(struct flexcop_usb *fc_usb) static int flexcop_usb_init(struct flexcop_usb *fc_usb) { /* use the alternate setting with the larges buffer */ - usb_set_interface(fc_usb->udev,0,1); + int ret = usb_set_interface(fc_usb->udev, 0, 1); + + if (ret) { + err("set interface failed."); + return ret; + } + switch (fc_usb->udev->speed) { case USB_SPEED_LOW: err("cannot handle USB speed because it is too slow."); -- 2.20.1