From: Andreas Kemnade <andreas@kemnade.info>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
stefan@agner.ch, b.galvani@gmail.com, phh@phh.me,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v3 3/6] mfd: rn5t618: add irq support
Date: Wed, 11 Dec 2019 12:43:20 +0100 [thread overview]
Message-ID: <20191211124320.5744531f@kemnade.info> (raw)
In-Reply-To: <20191211075021.GW3468@dell>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Wed, 11 Dec 2019 07:50:21 +0000
Lee Jones <lee.jones@linaro.org> wrote:
[...]
> > > > +
> > > > static const struct i2c_device_id rn5t618_i2c_id[] = {
> > > > { }
> > > > };
> > > > MODULE_DEVICE_TABLE(i2c, rn5t618_i2c_id);
> > >
> > > Not this patch I know, but it's strange to see this empty.
> >
> > Yes, should be cleaned up. For now the device tree stuff seems to kick in.
>
> I think this can be removed completely.
>
> Just make sure you use .probe2 and it should be automatic.
>
Hmm, I cannot find probe2 but probe_new. So you mean probe_new?
I will send a separate cleanup patch
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-12-11 11:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:20 [PATCH v3 0/6] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 1/6] dt-bindings: mfd: rn5t618: Document optional property interrupts Andreas Kemnade
2019-12-10 8:52 ` Lee Jones
2019-11-29 21:20 ` [PATCH v3 2/6] mfd: rn5t618: prepare for irq handling Andreas Kemnade
2019-12-10 9:13 ` Lee Jones
2019-12-10 17:06 ` Andreas Kemnade
2019-12-11 7:44 ` Lee Jones
2019-11-29 21:20 ` [PATCH v3 3/6] mfd: rn5t618: add irq support Andreas Kemnade
2019-12-10 9:32 ` Lee Jones
2019-12-10 16:59 ` Andreas Kemnade
2019-12-11 7:50 ` Lee Jones
2019-12-11 11:43 ` Andreas Kemnade [this message]
2019-11-29 21:20 ` [PATCH v3 4/6] mfd: rn5t618: add rtc related registers Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 5/6] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-11-29 21:20 ` [PATCH v3 6/6] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver Andreas Kemnade
2019-12-02 9:39 ` Alexandre Belloni
2019-12-11 19:33 ` Andreas Kemnade
2019-12-11 20:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211124320.5744531f@kemnade.info \
--to=andreas@kemnade.info \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.galvani@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=phh@phh.me \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).